correct info on url shortening behavior #2576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting to my understanding of the url shortening requirements
randyzwitch
reviewed
Jan 8, 2021
docs/deploy_streamlit_app.md
Outdated
| ``` | ||
|
|
||
| Most times, your app is also given a shortened URL of the form `https://share.streamlit.io/[user name]/[repo name]`. The only time you need the full URL is when you deployed multiple apps from the same repo. So you can also reach the example URL above at the short URL [http://share.streamlit.io/streamlit/demo-self-driving](http://share.streamlit.io/streamlit/demo-self-driving). | ||
| Most times, if your app has name `streamlit_app.py` and your branch is `master`, your app is also given a shortened URL of the form `https://share.streamlit.io/[user name]/[repo name]`. The only time you need the full URL is when you deployed multiple apps from the same repo. So you can also reach the example URL above at the short URL [http://share.streamlit.io/streamlit/demo-self-driving](http://share.streamlit.io/streamlit/demo-self-driving). |
Contributor
There was a problem hiding this comment.
Since this is so specific to the times when it occurs, should the beginning of the sentence remove "Most times"? If not, what are the situations when this doesn't occur automatically?
Contributor
Author
There was a problem hiding this comment.
I remembered why I kept it in... the sentence following shows another exception. But since that sentence remains, I agree it makes more sense to remove!
removed "most times."
akrolsmir
approved these changes
Jan 19, 2021
Contributor
akrolsmir
left a comment
akrolsmir
left a comment
There was a problem hiding this comment.
Thanks for updating this so our users can know how to get shortened URLs!
randyzwitch
approved these changes
Jan 21, 2021
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 25, 2021
* develop: ✨ Support "auto" as the new default for st.image's `use_column_width` (streamlit#2635) fix branch name in pr-preview (streamlit#2644) ♻️ Remove "_proto" from "exception_proto.py" (streamlit#2638) ♻️ Remove "_proto" from "media_proto.py" and "iframe_proto.py" (streamlit#2639) Refactor: remove "_proto" from "image_proto.py" (streamlit#2626) correct info on url shortening behavior (streamlit#2576) Set "overflow:visible" on st.expander (streamlit#2611) Revert "Revert "Add anchors to Markdown headers (streamlit#2513)"" Fix file uploader docs + change to getvalue (streamlit#2628) Update change log Update notices Up version to 0.75.0 Revert "Add anchors to Markdown headers (streamlit#2513)" Speed up Cypress tests (streamlit#2600) Remove "beta feature" notice on st.color_picker (streamlit#2625) Deflake multiselect snapshot test by waiting for stale-element (streamlit#2624) Rerender Maybe components when they're first disabled (streamlit#2617) Increase side padding to 5rem when app is in wide mode (streamlit#2613)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting to my understanding of the url shortening requirements
Before contributing (PLEASE READ!)
This helps make sure (1) two people aren't working on the same thing, (2) this is something Streamlit's maintainers believe should be implemented/fixed, (3) any API, UI, or deeper architectural changes that need to be implemented have been fully thought through by Streamlit's maintainers, and (4) your time is well spent!
More information in our wiki: https://github.com/streamlit/streamlit/wiki/Contributing
Issue: Please include a link to the issue you're addressing. If no issue exists, create one first and then link it here.
Description: Describe the changes you made to the code, so it's easier for the reader to navigate your pull request. Usually this is a bullet list.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.