Skip to content

Conversation

@tvst
Copy link
Contributor

@tvst tvst commented Jan 8, 2021

This is part 1 of our project to fix metrics (again).
Part 2 is to create a v3 metric that is just v1 minus sudo.
Part 3 is to remove the old metrics many months later.

This is part 1 of our project to fix metrics (again).
Part 2 is to create a v3 metric that is just v1 minus sudo.
Part 3 is to remove the old metrics many months later.
@tvst tvst requested a review from a team January 8, 2021 07:24
@tvst
Copy link
Contributor Author

tvst commented Jan 8, 2021

More info here, but the TLDR is:

  • installation_id_v2 inflated our metrics due to counting automated jobs like CI, etc, several times. This is not a problem for our internal dashboards because we can filter those out post-facto, but...
  • ...Segment charges us by user, which means it's charging us for all those extra installation_id_v2s
  • ...and it turns out instalaltion_id_v1 is as good as _v2 when we filter out automated jobs

So this PR goes back to v1, to reduce cost.

@tvst tvst merged commit 3e23180 into develop Jan 8, 2021
@tvst tvst deleted the fix-ids branch January 8, 2021 20:43
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 11, 2021
* develop: (21 commits)
  Remove depressing emojis (streamlit#2565)
  Go back to v1 metrics. (streamlit#2572)
  Up version to 0.74.1
  Revert "Upgrade react-hotkeys (streamlit#2525)"
  Revert "Upgrade react-markdown (streamlit#2527)"
  Revert "Revert "Deploy button py (streamlit#2535)""
  Revert "Deploy button py (streamlit#2535)"
  Update change log
  Update notices
  Up version to 0.74.0
  Update instructions placement on number input (streamlit#2549)
  Fix broken url (streamlit#2540)
  Deploy button front (streamlit#2552)
  Bump camelcase from 5.3.1 to 6.2.0 in /frontend (streamlit#2558)
  Fix block-container styles for sidebar (streamlit#2551)
  Bump @types/lodash from 4.14.165 to 4.14.167 in /frontend (streamlit#2550)
  Bump axios from 0.19.2 to 0.21.1 in /frontend (streamlit#2548)
  Remove deprecation message + add config expiration (streamlit#2546)
  Deploy button py (streamlit#2535)
  Remove aws-sdk (streamlit#2545)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants