Rename snapshot folders #2553
Merged
Rename snapshot folders #2553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karriebear
force-pushed
the
fix-snapshots
branch
from
194b943 to
b912456
Compare
karriebear
force-pushed
the
fix-snapshots
branch
from
7e9bc47 to
a70c478
Compare
karriebear
force-pushed
the
fix-snapshots
branch
from
3f6c1f0 to
54119b9
Compare
karriebear
force-pushed
the
fix-snapshots
branch
from
f434152 to
fb01423
Compare
karriebear
force-pushed
the
fix-snapshots
branch
from
fb01423 to
9cca8c6
Compare
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 12, 2021
* develop: Rename snapshot folders (streamlit#2553) Update FAQ to indicate components can go in the sidebar (streamlit#2589)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: As part of #2190 we renamed our E2E specs but did not rename the folders for the snapshots. This means that when matching snapshots, we are not able to find the right folder and instead are creating new snapshots instead of comparing with existing.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.