Deploy button front #2552
Merged
Deploy button front #2552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deploy-button-front # Conflicts: # proto/streamlit/proto/NewReport.proto
akrolsmir
approved these changes
Jan 5, 2021
Contributor
akrolsmir
left a comment
akrolsmir
left a comment
There was a problem hiding this comment.
LGTM! So excited to land this and get it in front of our users~
| msg.git_info_changed.state = GitInfo.GitStates.AHEAD_OF_REMOTE | ||
| else: | ||
| msg.git_info_changed.state = GitInfo.GitStates.DEFAULT | ||
|
|
Contributor
There was a problem hiding this comment.
It looks like before, we would always send an empty ForwardMsg even if something failed in our Git import; now, we don't send that ForwardMsg.
Just wanted to check -- was this change on purpose, and is it necessary? Since the rest of the PR is just frontend code, ideally we don't have to change the Python code here; but eg if this is needed for our logic to be correct, or a test to pass here, I'm okay with it.
Contributor
Author
There was a problem hiding this comment.
It was failing a test due to this because we've been sending an empty forwardmsg
Contributor
Author
There was a problem hiding this comment.
Should I do a separate PR for this?
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 11, 2021
* develop: (21 commits) Remove depressing emojis (streamlit#2565) Go back to v1 metrics. (streamlit#2572) Up version to 0.74.1 Revert "Upgrade react-hotkeys (streamlit#2525)" Revert "Upgrade react-markdown (streamlit#2527)" Revert "Revert "Deploy button py (streamlit#2535)"" Revert "Deploy button py (streamlit#2535)" Update change log Update notices Up version to 0.74.0 Update instructions placement on number input (streamlit#2549) Fix broken url (streamlit#2540) Deploy button front (streamlit#2552) Bump camelcase from 5.3.1 to 6.2.0 in /frontend (streamlit#2558) Fix block-container styles for sidebar (streamlit#2551) Bump @types/lodash from 4.14.165 to 4.14.167 in /frontend (streamlit#2550) Bump axios from 0.19.2 to 0.21.1 in /frontend (streamlit#2548) Remove deprecation message + add config expiration (streamlit#2546) Deploy button py (streamlit#2535) Remove aws-sdk (streamlit#2545) ...
tvst
added a commit
to tvst/streamlit
that referenced
this pull request
Jan 14, 2021
This reverts commit 0f66b6e.
tvst
added a commit
that referenced
this pull request
Jan 14, 2021
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 19, 2021
* develop: Feature/sudoless metrics (streamlit#2605) Have st.number_input warn user of mismatched type and format string (streamlit#2604) Remove extra period from sentence (streamlit#2601) Revert "Deploy button front (streamlit#2552)" (streamlit#2599) Fix slider UX (streamlit#2596)
CFrez
pushed a commit
to CFrez/streamlit
that referenced
this pull request
Jan 21, 2021
* Revert "Deploy button front (streamlit#2552)" This reverts commit 0f66b6e. * Fix merge (erm... revert) conflict. * Revert "Deploy button py (streamlit#2535)" This reverts commit 0bbc7aa. Co-authored-by: karrie <[email protected]>
kmcgrady
pushed a commit
that referenced
this pull request
Jan 25, 2021
* switched react-katex package * lockfile updated * update test to corrected spelling * decapitalize KaTex * Fix slider UX (#2596) * Fix slider UX * Add snapshot * Revert "Deploy button front (#2552)" (#2599) * Revert "Deploy button front (#2552)" This reverts commit 0f66b6e. * Fix merge (erm... revert) conflict. * Revert "Deploy button py (#2535)" This reverts commit 0bbc7aa. Co-authored-by: karrie <[email protected]> * Remove extra period from sentence (#2601) * Have st.number_input warn user of mismatched type and format string (#2604) * Add %u to list of valid number_input formatters * Have number_input warn user of mismatched type and format string * Use more modern f-string syntax instead of .format() * Feature/sudoless metrics (#2605) * Add and use sudoless machine id getter for metrics Step 2 of the metrics user ID improvement plan. * Add machine-id v3 tests Duplicates of the v1 tests, since those covered the cases that remain in v3, and we will remove v1 and its tests later. Also fix formatting of some python files. * DRY out machine ID paths into global constants * Increase side padding to 5rem when app is in wide mode (#2613) * Increase side padding to 5rem when app is in wide mode * Upload Cypress snapshot * Rerender Maybe components when they're first disabled (#2617) \#2395 ended up being caused by this since we don't rerender placeholder components created by `st.empty()` when react props/state change as a performance optimization, but we need to do so when replacing an existing component with an empty one to get rid of what's currently drawn on screen. Closes #2395 Co-authored-by: karrie <[email protected]> Co-authored-by: Thiago Teixeira <[email protected]> Co-authored-by: Randy Zwitch <[email protected]> Co-authored-by: Vincent Donato <[email protected]> Co-authored-by: Amanda Walker <[email protected]> Co-authored-by: Austin Chen <[email protected]> Co-authored-by: Vincent Donato <[email protected]>
kmcgrady
pushed a commit
to kmcgrady/streamlit
that referenced
this pull request
Mar 19, 2021
* Python side * format * import * todo * # * git binary or GitPython not installed * undo white spaces * undo white spaces * undo white spaces * handle_git_information_request * git_info_changed * Using enum * ahead_commits and uncommitted_files as properties * format * Frontend changes * Working with frontend changes * Deprecating deployParams * Unit tests working * deploy * snapshots * Fixing spec, and updating snapshot * Fixing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes https://app.clubhouse.io/streamlit/story/1871/improve-core-deploy-button-experience