Fix block-container styles for sidebar #2551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
approved these changes
Jan 5, 2021
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 11, 2021
* develop: (21 commits) Remove depressing emojis (streamlit#2565) Go back to v1 metrics. (streamlit#2572) Up version to 0.74.1 Revert "Upgrade react-hotkeys (streamlit#2525)" Revert "Upgrade react-markdown (streamlit#2527)" Revert "Revert "Deploy button py (streamlit#2535)"" Revert "Deploy button py (streamlit#2535)" Update change log Update notices Up version to 0.74.0 Update instructions placement on number input (streamlit#2549) Fix broken url (streamlit#2540) Deploy button front (streamlit#2552) Bump camelcase from 5.3.1 to 6.2.0 in /frontend (streamlit#2558) Fix block-container styles for sidebar (streamlit#2551) Bump @types/lodash from 4.14.165 to 4.14.167 in /frontend (streamlit#2550) Bump axios from 0.19.2 to 0.21.1 in /frontend (streamlit#2548) Remove deprecation message + add config expiration (streamlit#2546) Deploy button py (streamlit#2535) Remove aws-sdk (streamlit#2545) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Fixes #2468
Description:
ReportView should be styled based on if it is in the sidebar or not. Looking at v 0.68.0, embedded should only impact the header and not block container.
A snapshot image exists but did not trigger a failure initially because of issue resolved in #2553.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.