Skip to content

Conversation

@kmcgrady
Copy link
Collaborator

@kmcgrady kmcgrady commented Jan 5, 2021

Fixes #2516

  • This change adjusts the location of the instructions "Press Enter to apply", a minor bug introduced in the style refactor.
  • More subtly, there was a rounded rectangle in the input that was incorrect and was fixed (this likely would not be picked up in the e2e tests).
  • An e2e tests to verify the instructions placement via image snapshot.

Updated Look (same before the bug is re-introduced)
image

@kmcgrady kmcgrady requested a review from a team January 5, 2021 01:07
Copy link
Contributor

@akrolsmir akrolsmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it looks as expected on PR Preview!

@akrolsmir akrolsmir merged commit 7d89e55 into streamlit:develop Jan 6, 2021
@kmcgrady kmcgrady deleted the CORE-787 branch January 6, 2021 20:33
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 11, 2021
* develop: (21 commits)
  Remove depressing emojis (streamlit#2565)
  Go back to v1 metrics. (streamlit#2572)
  Up version to 0.74.1
  Revert "Upgrade react-hotkeys (streamlit#2525)"
  Revert "Upgrade react-markdown (streamlit#2527)"
  Revert "Revert "Deploy button py (streamlit#2535)""
  Revert "Deploy button py (streamlit#2535)"
  Update change log
  Update notices
  Up version to 0.74.0
  Update instructions placement on number input (streamlit#2549)
  Fix broken url (streamlit#2540)
  Deploy button front (streamlit#2552)
  Bump camelcase from 5.3.1 to 6.2.0 in /frontend (streamlit#2558)
  Fix block-container styles for sidebar (streamlit#2551)
  Bump @types/lodash from 4.14.165 to 4.14.167 in /frontend (streamlit#2550)
  Bump axios from 0.19.2 to 0.21.1 in /frontend (streamlit#2548)
  Remove deprecation message + add config expiration (streamlit#2546)
  Deploy button py (streamlit#2535)
  Remove aws-sdk (streamlit#2545)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Press Enter to apply' overlaps in Widget

2 participants