Fix broken url #2540
Merged
Fix broken url #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrolsmir
reviewed
Dec 31, 2020
Contributor
akrolsmir
left a comment
akrolsmir
left a comment
There was a problem hiding this comment.
Hi @gcamargo1 -- Thanks for catching this and suggesting a fix! I just did a quick search over our codebase and it looks like there are a couple other places where we use the same broken URL (installation.md and main_concepts.md); would you mind updating those as well?
…/master/streamlit_app.py link in installation.md and main_concepts.md
Contributor
Author
|
Hi @akrolsmir , just did the updates you've suggested. Let me know if this works. thanks. |
akrolsmir
approved these changes
Jan 4, 2021
Contributor
akrolsmir
left a comment
akrolsmir
left a comment
There was a problem hiding this comment.
Yup, this looks great. Thanks again!
randyzwitch
approved these changes
Jan 4, 2021
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 11, 2021
* develop: (21 commits) Remove depressing emojis (streamlit#2565) Go back to v1 metrics. (streamlit#2572) Up version to 0.74.1 Revert "Upgrade react-hotkeys (streamlit#2525)" Revert "Upgrade react-markdown (streamlit#2527)" Revert "Revert "Deploy button py (streamlit#2535)"" Revert "Deploy button py (streamlit#2535)" Update change log Update notices Up version to 0.74.0 Update instructions placement on number input (streamlit#2549) Fix broken url (streamlit#2540) Deploy button front (streamlit#2552) Bump camelcase from 5.3.1 to 6.2.0 in /frontend (streamlit#2558) Fix block-container styles for sidebar (streamlit#2551) Bump @types/lodash from 4.14.165 to 4.14.167 in /frontend (streamlit#2550) Bump axios from 0.19.2 to 0.21.1 in /frontend (streamlit#2548) Remove deprecation message + add config expiration (streamlit#2546) Deploy button py (streamlit#2535) Remove aws-sdk (streamlit#2545) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct URL:
https://raw.githubusercontent.com/streamlit/demo-uber-nyc-pickups/master/streamlit_app.py
Before contributing (PLEASE READ!)
This helps make sure (1) two people aren't working on the same thing, (2) this is something Streamlit's maintainers believe should be implemented/fixed, (3) any API, UI, or deeper architectural changes that need to be implemented have been fully thought through by Streamlit's maintainers, and (4) your time is well spent!
More information in our wiki: https://github.com/streamlit/streamlit/wiki/Contributing
Issue: Please include a link to the issue you're addressing. If no issue exists, create one first and then link it here.
Description: Describe the changes you made to the code, so it's easier for the reader to navigate your pull request. Usually this is a bullet list.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.