Upgrade react-markdown #2527
Merged
Upgrade react-markdown #2527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantuni
commented
Dec 28, 2020
| expect(els[3].textContent).to.eq("[text]"); | ||
| expect(els[4].textContent).to.eq("link"); | ||
| expect(els[5].textContent).to.eq(""); | ||
| expect(els[5].textContent).to.eq("[][]"); |
Collaborator
Author
There was a problem hiding this comment.
This unit test has been broken. The old version of react-markdown had a bug that incorrectly rendered this case.
Contributor
There was a problem hiding this comment.
Huh, interesting. I took a look at the Git blame where we introduced this unit test, but intuitively it makes sense that "[][]" should render as that and not empty string, in Markdown.
This was referenced Dec 28, 2020
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.19.9 to 14.14.16. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
akrolsmir
approved these changes
Dec 28, 2020
| expect(els[3].textContent).to.eq("[text]"); | ||
| expect(els[4].textContent).to.eq("link"); | ||
| expect(els[5].textContent).to.eq(""); | ||
| expect(els[5].textContent).to.eq("[][]"); |
Contributor
There was a problem hiding this comment.
Huh, interesting. I took a look at the Git blame where we introduced this unit test, but intuitively it makes sense that "[][]" should render as that and not empty string, in Markdown.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 4, 2021
* develop: Bump vega from 5.17.1 to 5.17.3 in /frontend (streamlit#2541) Pick a random emoji on `st.set_page_config(emoji="random")` (streamlit#2020) Fix Jest warnings (streamlit#2523) Upgrade react-markdown (streamlit#2527) Upgrade react-hotkeys (streamlit#2525) Close streamlit#2495 (streamlit#2524) Remove unnecessary case statement (streamlit#2522) Bump @types/node from 12.19.9 to 14.14.16 in /frontend (streamlit#2526) Bump fetch-mock from 7.7.3 to 9.11.0 in /frontend (streamlit#2505) st.markdown now shows a link title (streamlit#2518) Bump @types/react-dom from 16.9.10 to 17.0.0 in /frontend (streamlit#2503) Fix caching list comprehensions (streamlit#2484) Add validation to st.slider ensuring `step` cannot be 0 (streamlit#2502) Ensure st.image works with UploadedFiles (streamlit#2512) Fix dataframe column sort (streamlit#2511) File uploader session check (streamlit#2498) Upgrade node-notifier to 8.0.1 or later (streamlit#2507) Fix st.number_input not using min_value as default value (streamlit#2499) Unblock Core patches, and add Marisa as a docs owner (streamlit#2501) Patch 0.73.1 (streamlit#2500)
karriebear
added a commit
to karriebear/streamlit
that referenced
this pull request
Jan 7, 2021
This reverts commit 1739b84.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 11, 2021
* develop: (21 commits) Remove depressing emojis (streamlit#2565) Go back to v1 metrics. (streamlit#2572) Up version to 0.74.1 Revert "Upgrade react-hotkeys (streamlit#2525)" Revert "Upgrade react-markdown (streamlit#2527)" Revert "Revert "Deploy button py (streamlit#2535)"" Revert "Deploy button py (streamlit#2535)" Update change log Update notices Up version to 0.74.0 Update instructions placement on number input (streamlit#2549) Fix broken url (streamlit#2540) Deploy button front (streamlit#2552) Bump camelcase from 5.3.1 to 6.2.0 in /frontend (streamlit#2558) Fix block-container styles for sidebar (streamlit#2551) Bump @types/lodash from 4.14.165 to 4.14.167 in /frontend (streamlit#2550) Bump axios from 0.19.2 to 0.21.1 in /frontend (streamlit#2548) Remove deprecation message + add config expiration (streamlit#2546) Deploy button py (streamlit#2535) Remove aws-sdk (streamlit#2545) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list:
react-markdownfrom 4.3.1 to 5.0.3remark-mathfrom 2.0.1 to 4.0.0