Skip to content

Conversation

@kantuni
Copy link
Collaborator

@kantuni kantuni commented Dec 28, 2020

@kantuni kantuni requested a review from a team December 28, 2020 12:18
@kantuni kantuni force-pushed the upgrade/react-hotkeys branch from c300800 to 18ed369 Compare December 28, 2020 12:49
Copy link
Contributor

@akrolsmir akrolsmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent change for code cleanliness; love that there are more lines of code being deleted than added.

I briefly tested and confirmed it works on PR-preview (at least, "R" to refresh and "Esc" to stop recording)

@akrolsmir akrolsmir merged commit 72d9a11 into streamlit:develop Dec 28, 2020
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 4, 2021
* develop:
  Bump vega from 5.17.1 to 5.17.3 in /frontend (streamlit#2541)
  Pick a random emoji on `st.set_page_config(emoji="random")` (streamlit#2020)
  Fix Jest warnings (streamlit#2523)
  Upgrade react-markdown (streamlit#2527)
  Upgrade react-hotkeys (streamlit#2525)
  Close streamlit#2495 (streamlit#2524)
  Remove unnecessary case statement (streamlit#2522)
  Bump @types/node from 12.19.9 to 14.14.16 in /frontend (streamlit#2526)
  Bump fetch-mock from 7.7.3 to 9.11.0 in /frontend (streamlit#2505)
  st.markdown now shows a link title (streamlit#2518)
  Bump @types/react-dom from 16.9.10 to 17.0.0 in /frontend (streamlit#2503)
  Fix caching list comprehensions (streamlit#2484)
  Add validation to st.slider ensuring `step` cannot be 0 (streamlit#2502)
  Ensure st.image works with UploadedFiles (streamlit#2512)
  Fix dataframe column sort (streamlit#2511)
  File uploader session check (streamlit#2498)
  Upgrade node-notifier to 8.0.1 or later (streamlit#2507)
  Fix st.number_input not using min_value as default value (streamlit#2499)
  Unblock Core patches, and add Marisa as a docs owner (streamlit#2501)
  Patch 0.73.1 (streamlit#2500)
karriebear added a commit to karriebear/streamlit that referenced this pull request Jan 7, 2021
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 11, 2021
* develop: (21 commits)
  Remove depressing emojis (streamlit#2565)
  Go back to v1 metrics. (streamlit#2572)
  Up version to 0.74.1
  Revert "Upgrade react-hotkeys (streamlit#2525)"
  Revert "Upgrade react-markdown (streamlit#2527)"
  Revert "Revert "Deploy button py (streamlit#2535)""
  Revert "Deploy button py (streamlit#2535)"
  Update change log
  Update notices
  Up version to 0.74.0
  Update instructions placement on number input (streamlit#2549)
  Fix broken url (streamlit#2540)
  Deploy button front (streamlit#2552)
  Bump camelcase from 5.3.1 to 6.2.0 in /frontend (streamlit#2558)
  Fix block-container styles for sidebar (streamlit#2551)
  Bump @types/lodash from 4.14.165 to 4.14.167 in /frontend (streamlit#2550)
  Bump axios from 0.19.2 to 0.21.1 in /frontend (streamlit#2548)
  Remove deprecation message + add config expiration (streamlit#2546)
  Deploy button py (streamlit#2535)
  Remove aws-sdk (streamlit#2545)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants