Skip to content

Conversation

@kantuni
Copy link
Collaborator

@kantuni kantuni commented Dec 24, 2020

Change list:

  • Added support for title argument in a tags.
  • Added unit tests to check the title argument.
  • Refactored old unit tests.
  • Removed react-test-renderer from dependencies as we're not using it anymore.

@kantuni kantuni requested a review from a team December 24, 2020 14:00
Copy link
Contributor

@akrolsmir akrolsmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Christmas present! Not only is Streamlit markdown more accessible, the codebase is now cleaner too 👍

@akrolsmir akrolsmir merged commit 940d3a2 into streamlit:develop Dec 24, 2020
@kantuni kantuni deleted the feature/markdown-link-title branch December 27, 2020 09:58
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 4, 2021
* develop:
  Bump vega from 5.17.1 to 5.17.3 in /frontend (streamlit#2541)
  Pick a random emoji on `st.set_page_config(emoji="random")` (streamlit#2020)
  Fix Jest warnings (streamlit#2523)
  Upgrade react-markdown (streamlit#2527)
  Upgrade react-hotkeys (streamlit#2525)
  Close streamlit#2495 (streamlit#2524)
  Remove unnecessary case statement (streamlit#2522)
  Bump @types/node from 12.19.9 to 14.14.16 in /frontend (streamlit#2526)
  Bump fetch-mock from 7.7.3 to 9.11.0 in /frontend (streamlit#2505)
  st.markdown now shows a link title (streamlit#2518)
  Bump @types/react-dom from 16.9.10 to 17.0.0 in /frontend (streamlit#2503)
  Fix caching list comprehensions (streamlit#2484)
  Add validation to st.slider ensuring `step` cannot be 0 (streamlit#2502)
  Ensure st.image works with UploadedFiles (streamlit#2512)
  Fix dataframe column sort (streamlit#2511)
  File uploader session check (streamlit#2498)
  Upgrade node-notifier to 8.0.1 or later (streamlit#2507)
  Fix st.number_input not using min_value as default value (streamlit#2499)
  Unblock Core patches, and add Marisa as a docs owner (streamlit#2501)
  Patch 0.73.1 (streamlit#2500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants