Add validation to st.slider ensuring step cannot be 0
#2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
ghost
changed the title
step cannot be 0.step cannot be 0
ghost
changed the title
step cannot be 0step cannot be 0
ghost
changed the title
step cannot be 0step cannot be 0
Contributor
|
Hm, looks like a flaky test, since File Uploader should be unrelated to any code changes here: This test has been flaky before; we tried #2438 to fix it, but looks it may need more work... For now, rerunning tests in CircleCI to unblock this PR |
akrolsmir
approved these changes
Dec 22, 2020
Contributor
akrolsmir
left a comment
akrolsmir
left a comment
There was a problem hiding this comment.
Looks good to me! Passes on PR-Preview
import streamlit as st
input_step = st.number_input("Step")
my_range = st.slider("Range", 20, 120, step=int(input_step))
We may want @asaini to take a look, for product approval on the string? It's very minor though.
|
LGTM 👍 |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 4, 2021
* develop: Bump vega from 5.17.1 to 5.17.3 in /frontend (streamlit#2541) Pick a random emoji on `st.set_page_config(emoji="random")` (streamlit#2020) Fix Jest warnings (streamlit#2523) Upgrade react-markdown (streamlit#2527) Upgrade react-hotkeys (streamlit#2525) Close streamlit#2495 (streamlit#2524) Remove unnecessary case statement (streamlit#2522) Bump @types/node from 12.19.9 to 14.14.16 in /frontend (streamlit#2526) Bump fetch-mock from 7.7.3 to 9.11.0 in /frontend (streamlit#2505) st.markdown now shows a link title (streamlit#2518) Bump @types/react-dom from 16.9.10 to 17.0.0 in /frontend (streamlit#2503) Fix caching list comprehensions (streamlit#2484) Add validation to st.slider ensuring `step` cannot be 0 (streamlit#2502) Ensure st.image works with UploadedFiles (streamlit#2512) Fix dataframe column sort (streamlit#2511) File uploader session check (streamlit#2498) Upgrade node-notifier to 8.0.1 or later (streamlit#2507) Fix st.number_input not using min_value as default value (streamlit#2499) Unblock Core patches, and add Marisa as a docs owner (streamlit#2501) Patch 0.73.1 (streamlit#2500)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2497.
The issue isn't with
st.number_input(), which wonderfully, correctly defaults to 0.0. The issue isst.slider()being passed astepof 0, which it's directly forwarding to BaseUI's Slider, which one can imagine is presumably is doing something likefor (var curr = start; curr < end; curr += step)and dying in an infinite loop.This PR:
stepto make sure it isn't 0