Skip to content

Remove the unused variables inside protos #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akrolsmir merged 3 commits into from
Dec 19, 2020
Merged

Remove the unused variables inside protos #2486

akrolsmir merged 3 commits into from
Dec 19, 2020

Conversation

@akrolsmir
Copy link
Contributor

@akrolsmir akrolsmir commented Dec 19, 2020

No description provided.

@akrolsmir akrolsmir changed the title WIP try removing the unused variables inside protos Remove the unused variables inside protos Dec 19, 2020
@akrolsmir akrolsmir marked this pull request as ready for review December 19, 2020 05:35
@akrolsmir akrolsmir requested a review from a team December 19, 2020 05:35
kantuni
kantuni approved these changes Dec 19, 2020
View reviewed changes
Copy link
Collaborator

@kantuni kantuni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖖

@akrolsmir akrolsmir merged commit 0449f11 into streamlit:develop Dec 19, 2020
@akrolsmir akrolsmir mentioned this pull request Dec 19, 2020
Closed
tconkling added a commit to tconkling/streamlit that referenced this pull request Dec 21, 2020
@tconkling
Merge branch 'develop' into tim/FormProto
7704f36 
* develop:
  Extract st.container, columns, container out of delta_generator.py (streamlit#2487)
  Remove the unused variables inside protos (streamlit#2486)
  Stop running cypress-flaky-approval for each PR (streamlit#2490)
  Dynamically import git, and fail gracefully if missing (streamlit#2482)
  Bump React to 17.0.1 (streamlit#2453)
  Fix emojis (streamlit#2480)
  Add missing copyright headers (streamlit#2478)
  Stop requiring watchdog when installing Streamlit on Macs (streamlit#2470)
  Minor tweak to PyArrow warning message (streamlit#2472)
  Use a set literal (streamlit#2476)
  Add type annotations to DeltaGenerator mixins (streamlit#2475)
  Update change log
  Up version to 0.73.0
  Don't require pyarrow on 3.9, and show a warning on custom components (streamlit#2452)
@akrolsmir akrolsmir deleted the empty-protos branch January 19, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kantuni kantuni kantuni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akrolsmir @kantuni