Fix emojis #2480
Merged
Fix emojis #2480
+33
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix emojis breaking with shortcodes containing dashes - Fix emojis breaking with variants - Add tests for both cases
ghost
self-requested a review
akrolsmir
approved these changes
Dec 18, 2020
Contributor
akrolsmir
left a comment
akrolsmir
left a comment
There was a problem hiding this comment.
Awesome work! Especially great to be leveraging existing code from twemoji, I totally did not realize that was already there 🤦
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Dec 21, 2020
* develop: Extract st.container, columns, container out of delta_generator.py (streamlit#2487) Remove the unused variables inside protos (streamlit#2486) Stop running cypress-flaky-approval for each PR (streamlit#2490) Dynamically import git, and fail gracefully if missing (streamlit#2482) Bump React to 17.0.1 (streamlit#2453) Fix emojis (streamlit#2480) Add missing copyright headers (streamlit#2478) Stop requiring watchdog when installing Streamlit on Macs (streamlit#2470) Minor tweak to PyArrow warning message (streamlit#2472) Use a set literal (streamlit#2476) Add type annotations to DeltaGenerator mixins (streamlit#2475) Update change log Up version to 0.73.0 Don't require pyarrow on 3.9, and show a warning on custom components (streamlit#2452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1894 and #2394 and adds tests for both cases.
Emojis with variants: The twemoji library actually provides logic that handles this in a wrapper function around
toCodePointcalledgrabTheRightIcon, so I just imported that and used that instead.Shortcodes: node-emoji expects underscores instead of dashes, so I did a string replacement.