Skip to content

Add missing copyright headers #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akrolsmir merged 1 commit into from
Dec 17, 2020
Merged

Add missing copyright headers #2478

akrolsmir merged 1 commit into from
Dec 17, 2020

Conversation

@tconkling
Copy link
Contributor

@tconkling tconkling commented Dec 17, 2020

No description provided.

@tconkling tconkling requested a review from a team December 17, 2020 18:24
akrolsmir
akrolsmir approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@akrolsmir akrolsmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 * 21 = 294 LOC, easy LGTM

@akrolsmir
Copy link
Contributor

akrolsmir commented Dec 17, 2020 •
edited
Loading

Hm, seems to be a flaky test:

hello displays dataframe demo - displays dataframe demo
Error: Image was 19.275282118055557% different from saved snapshot with 177641 different pixels.
See diff for details: /home/circleci/repo/frontend/cypress/snapshots/linux/2x/st_hello.spec.js/diff_output/dataframe-demo.diff.png
at Context.eval (http://localhost:3000/__cypress/tests?p=cypress/support/index.js:2787:17)

Just rerunning for now; will note if the same test flakes in the future.

@akrolsmir akrolsmir merged commit be876b0 into streamlit:develop Dec 17, 2020
tconkling added a commit to tconkling/streamlit that referenced this pull request Dec 21, 2020
@tconkling
Merge branch 'develop' into tim/FormProto
7704f36 
* develop:
  Extract st.container, columns, container out of delta_generator.py (streamlit#2487)
  Remove the unused variables inside protos (streamlit#2486)
  Stop running cypress-flaky-approval for each PR (streamlit#2490)
  Dynamically import git, and fail gracefully if missing (streamlit#2482)
  Bump React to 17.0.1 (streamlit#2453)
  Fix emojis (streamlit#2480)
  Add missing copyright headers (streamlit#2478)
  Stop requiring watchdog when installing Streamlit on Macs (streamlit#2470)
  Minor tweak to PyArrow warning message (streamlit#2472)
  Use a set literal (streamlit#2476)
  Add type annotations to DeltaGenerator mixins (streamlit#2475)
  Update change log
  Up version to 0.73.0
  Don't require pyarrow on 3.9, and show a warning on custom components (streamlit#2452)
@tconkling tconkling deleted the tim/MissingCopyrightHeaders branch January 27, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@akrolsmir akrolsmir akrolsmir approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tconkling @akrolsmir