Stop requiring watchdog when installing Streamlit on Macs #2470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karriebear
approved these changes
Dec 17, 2020
Contributor
karriebear
left a comment
karriebear
left a comment
There was a problem hiding this comment.
I don't love the solution but haven't been able to find a better conditional dependency we can use instead. The only thing is more people will now see the below message but guess that's better than failing... Would love some classier solution in the future.
Side note, the performance change doesn't seem to be noticeable for local development which I assume is where you would see MacOS being used with Streamlit.
For better performance, install the Watchdog module:
$ xcode-select --install
$ pip install watchdog
Contributor
Author
|
Agreed that I wish we could do better (mostly -- if we could do exactly what was suggested in setup.py, aka install watchdog if xcode tools and gcc are already there). But I didn't see a clear path to that either, and merging this in is an improvement upon the current situation. |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Dec 21, 2020
* develop: Extract st.container, columns, container out of delta_generator.py (streamlit#2487) Remove the unused variables inside protos (streamlit#2486) Stop running cypress-flaky-approval for each PR (streamlit#2490) Dynamically import git, and fail gracefully if missing (streamlit#2482) Bump React to 17.0.1 (streamlit#2453) Fix emojis (streamlit#2480) Add missing copyright headers (streamlit#2478) Stop requiring watchdog when installing Streamlit on Macs (streamlit#2470) Minor tweak to PyArrow warning message (streamlit#2472) Use a set literal (streamlit#2476) Add type annotations to DeltaGenerator mixins (streamlit#2475) Update change log Up version to 0.73.0 Don't require pyarrow on 3.9, and show a warning on custom components (streamlit#2452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283
Pros: No one will ever have a problem installing Streamlit on Macs due to watchdog again
Cons: Mac users will use the slower(?) poll-based file watcher by default.
But we show them a command line warning, advising them to install watchdog themselves with
xcode-select --install; pip install watchdogThe old check in
setup.pywas only run when a user installs Streamlit from source, but most of the time (e.g.pip install streamlit) will install from the binary wheelfile, so the check insetup.pywill go unused. See #2452 for more information.