Skip to content

Disable Git integration for ancient Gits #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tconkling merged 5 commits into from
Dec 3, 2020
Merged

Disable Git integration for ancient Gits #2403

tconkling merged 5 commits into from
Dec 3, 2020

Conversation

@tconkling
Copy link
Contributor

@tconkling tconkling commented Dec 1, 2020 •
edited
Loading

If the user is using a version of Git < 2.7.0, disable Git integration (to prevent GitPython from prompting for credentials), and warn the user to upgrade their Git:

Screen Shot 2020-12-01 at 1 31 47 PM

The text needs a product pass:

  • Do we want it above or below the Streamlit welcome text?
  • Should we be more specific about what Git integration means? (Possibly link to docs?)
  • Should we be less prominent with this warning? Maybe it's just a single line?
  Git integration is disabled.

  Streamlit requires Git 2.7.0 or later, but you have 2.6.4.
  To use Streamlit's Git integration, please update Git.

Fixes #2323

@tconkling tconkling requested a review from a team December 1, 2020 18:37
kantuni
kantuni approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@kantuni kantuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asaini
Copy link

asaini commented Dec 2, 2020

Text above the Streamlit welcome text looks good

Should we be more specific about what Git integration means? (Possibly link to docs?) - I think we can add 'why' Streamlit requires Git integration(my understanding is that we need it for S4A)

Git integration is disabled.

Streamlit requires Git 2.7.0 or later, but you have 2.6.4.
Git is used as part of Streamlit Sharing(streamlit.io/sharing). To enable this feature, please update Git.

@tconkling
Merge branch 'develop' into tim/OldGit
f48b78f 
* develop:
  Components: send "key" and "default" to frontend (streamlit#2405)
  Consolidate reruns for multiple file uploads (streamlit#2372)
  Use all long hand styles (streamlit#2402)
  Make `python -m streamlit` work (streamlit#2351)
  un-pin opencv (streamlit#2396)
  docs: Add 21YunBox for deployment (streamlit#2392)
@tconkling
Updated "old git" warning message
89ea0b5
@tconkling tconkling merged commit b1c99ba into streamlit:develop Dec 3, 2020
@tconkling tconkling deleted the tim/OldGit branch December 3, 2020 15:52
@asaini
Copy link

asaini commented Dec 3, 2020

👍

tconkling added a commit to tconkling/streamlit that referenced this pull request Dec 7, 2020
@tconkling
Merge branch 'develop' into tim/UniqueUploadedFile
f937da2 
* develop:
  Remove hidden config options from docs (streamlit#2412)
  Remove unused SCSS Vars (streamlit#2415)
  Bump plotly.js to 1.58.0 (streamlit#2413)
  Disable Git integration for ancient Gits (streamlit#2403)
  Update notices
  Up version to 0.72.0
  Update change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kantuni kantuni kantuni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using git below version 2.7 requires remote (e.g. GitHub) credentials on every run (for private repos)

3 participants

@tconkling @asaini @kantuni