Read config from ${CWD}/.streamlit/config.toml#227
Merged
tconkling merged 10 commits intostreamlit:developfrom Oct 8, 2019
Merged
Read config from ${CWD}/.streamlit/config.toml#227tconkling merged 10 commits intostreamlit:developfrom
tconkling merged 10 commits intostreamlit:developfrom
Conversation
jrhone
reviewed
Oct 2, 2019
jrhone
approved these changes
Oct 4, 2019
Contributor
jrhone
left a comment
jrhone
left a comment
There was a problem hiding this comment.
Think it looks good with the suggested change
tvst
approved these changes
Oct 4, 2019
| """Return the full path to a filepath in ~/.streamlit. | ||
| """Return the full path to a file in ~/.streamlit. | ||
|
|
||
| Creates ~/.streamlit if needed. |
Contributor
There was a problem hiding this comment.
Since this PR removes this (which I think is the right thing to do), please try deleting config.toml and credentials.toml and then running Streamlit to see if anything breaks.
The missing credentials.toml should cause Streamlit to ask for the user's email, and then create the credentials file.
The missing config.toml should not make any difference. Streamlist should just work.
* develop: Support cli parameters (streamlit#186) Update README.md Update README.md (streamlit#282) Bug fix: make Streamlit watch files in subfolders again (streamlit#265) fix st.code("") (streamlit#272) different jslint commands for circleci and not (streamlit#273) Batch updates to report elements in the App state (streamlit#194) Minor typo in pull_request_template.md (streamlit#262) Fix wrong quote used in the provided sample code (streamlit#267) Fix websocket port handling (streamlit#263) Closing sidebar when clicking outside (streamlit#223) Version 0.47.2 (streamlit#212) [docs] Changed value in Show progress section of docs/getting_started.md to fix error (Issue streamlit#234) (streamlit#235) Update README.md Remove checkbox from CLA in PR Template Update README.md Update README.md mapping_demo: catch urllib errors (streamlit#224)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Oct 8, 2019
* develop:
Read config from ${CWD}/.streamlit/config.toml (streamlit#227)
Fix unsafe_allow_html (streamlit#259)
Support cli parameters (streamlit#186)
Update README.md
Update README.md (streamlit#282)
Bug fix: make Streamlit watch files in subfolders again (streamlit#265)
fix st.code("") (streamlit#272)
different jslint commands for circleci and not (streamlit#273)
Batch updates to report elements in the App state (streamlit#194)
Minor typo in pull_request_template.md (streamlit#262)
Fix wrong quote used in the provided sample code (streamlit#267)
Fix websocket port handling (streamlit#263)
Closing sidebar when clicking outside (streamlit#223)
Version 0.47.2 (streamlit#212)
[docs] Changed value in Show progress section of docs/getting_started.md to fix error (Issue streamlit#234) (streamlit#235)
Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a project has a config.toml at
${cwd}/.streamlit/config.toml, it's merged with the global config.toml (with the local config taking precedence for any options that are defined twice).This also makes some minor API changes:
util.get_streamlit_file_pathno longer intermediate directories for the file. Instead, the few places that need to ensure those directories exist callos.makedirswhen appropriate.config.parse_config_fileno longer takes an optionalfile_contentsparam. This was only used for tests; the tests now properly patch theos.openos.path.existsandos.makedirscalls.Fixes #221