Skip to content

Closing sidebar when clicking outside#223

Merged
arraydude merged 9 commits intostreamlit:developfrom
arraydude:close-sidebar-clicking-outside
Oct 3, 2019
Merged

Closing sidebar when clicking outside#223
arraydude merged 9 commits intostreamlit:developfrom
arraydude:close-sidebar-clicking-outside

Conversation

@arraydude
Copy link
Copy Markdown
Contributor

Closing the sidebar when:

1 - The user clicks outside of it
2 - When the viewport is within the mobile breakpoint

@arraydude arraydude requested a review from tvst October 1, 2019 18:00
@jrhone
Copy link
Copy Markdown
Contributor

jrhone commented Oct 2, 2019

Is there an issue for this?

@arraydude
Copy link
Copy Markdown
Contributor Author

Is there an issue for this?

There's no issue for this, we chatted with @tvst about this through slack

@arraydude arraydude merged commit f3bcf40 into streamlit:develop Oct 3, 2019
@arraydude arraydude deleted the close-sidebar-clicking-outside branch October 3, 2019 20:07
tconkling added a commit to tconkling/streamlit that referenced this pull request Oct 7, 2019
* develop:
  Support cli parameters (streamlit#186)
  Update README.md
  Update README.md (streamlit#282)
  Bug fix: make Streamlit watch files in subfolders again (streamlit#265)
  fix st.code("") (streamlit#272)
  different jslint commands for circleci and not (streamlit#273)
  Batch updates to report elements in the App state (streamlit#194)
  Minor typo in pull_request_template.md (streamlit#262)
  Fix wrong quote used in the provided sample code (streamlit#267)
  Fix websocket port handling (streamlit#263)
  Closing sidebar when clicking outside (streamlit#223)
  Version 0.47.2 (streamlit#212)
  [docs] Changed value in Show progress section of docs/getting_started.md to fix error (Issue streamlit#234) (streamlit#235)
  Update README.md
  Remove checkbox from CLA in PR Template
  Update README.md
  Update README.md
  mapping_demo: catch urllib errors (streamlit#224)
tconkling added a commit to tconkling/streamlit that referenced this pull request Oct 8, 2019
* develop:
  Read config from ${CWD}/.streamlit/config.toml (streamlit#227)
  Fix unsafe_allow_html (streamlit#259)
  Support cli parameters (streamlit#186)
  Update README.md
  Update README.md (streamlit#282)
  Bug fix: make Streamlit watch files in subfolders again (streamlit#265)
  fix st.code("") (streamlit#272)
  different jslint commands for circleci and not (streamlit#273)
  Batch updates to report elements in the App state (streamlit#194)
  Minor typo in pull_request_template.md (streamlit#262)
  Fix wrong quote used in the provided sample code (streamlit#267)
  Fix websocket port handling (streamlit#263)
  Closing sidebar when clicking outside (streamlit#223)
  Version 0.47.2 (streamlit#212)
  [docs] Changed value in Show progress section of docs/getting_started.md to fix error (Issue streamlit#234) (streamlit#235)
  Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants