Don't wait for unit tests before starting Cypress#2142
Don't wait for unit tests before starting Cypress#2142akrolsmir merged 1 commit intostreamlit:developfrom
Conversation
python-3-8 typically takes 6 minutes to run; we might as well start running Cypress in parallel (which takes ~28min). This way the maximum PR submission time goes down from 34 to 28 minutes.
|
This seems fine with me, but do we waste resources (that we pay for) running cypress tests that would be saved if it waits for 3.8? If no (or we do and it doesn't matter), that's fine. I guess I might just argue the value of the 6 mins if it will cost more money, but I'm probably just being crazy. |
Yeah, that's the main issue. But we get like a bunch of free credit anyways, I'm not even sure we use up all of it rn. Most PRs end up going through the cypress tests anyways, so the savings are a pretty small % of our CircleCI budget (I'd guess no more than 20%). My take is we should spend money on literally anything that makes us more productive and it's biz's job to tell us to stop. |
# By karrie (7) and others # Via GitHub * develop: Removing cache option from main menu if s4a (streamlit#2149) Fix empty deploy page (streamlit#2148) Don't wait for unit tests before starting Cypress (streamlit#2142) Fix formatting of st.file_uploader docstring (streamlit#2141) Fix broken link in 0.68 changelog (streamlit#2144) Fix useEffect warning (streamlit#2137) Add global GTM container (streamlit#2128) Allow Streamlit server to handle Range Requests (streamlit#1967) rename hosted to hostedAt (streamlit#2132) Update change log Update notices Up version to 0.68.0 Rename hosted to hostedAt in tracking data (streamlit#2132) Inject tracking data (streamlit#2110) [Feature Branch] File uploader (streamlit#2130) links for docs (streamlit#2129) Upgrade ProtobufJS and fix build script (streamlit#2118) Refresh landing page (streamlit#2116) Improve docstrings + tutorials for Layout (streamlit#2117) Better 'streamlit run' error message when no extension provided (streamlit#2115) # Conflicts: # frontend/src/components/elements/Video/Video.tsx # frontend/src/components/widgets/FileUploader/FileUploader.test.tsx # frontend/src/components/widgets/FileUploader/FileUploader.tsx # frontend/src/lib/utils.ts
2 participants
python-3-8 typically takes 6 minutes to run; we might as well start running Cypress in parallel (which takes ~28min).
This way the maximum PR submission time goes down from 34 to 28 minutes.