Skip to content

Fix useEffect warning#2137

Merged
karriebear merged 1 commit intostreamlit:developfrom
karriebear:use-effect-pagination-warning
Oct 9, 2020
Merged

Fix useEffect warning#2137
karriebear merged 1 commit intostreamlit:developfrom
karriebear:use-effect-pagination-warning

Conversation

@karriebear
Copy link
Copy Markdown
Contributor

Issue: Nightly failure

Description: Missed a warning for useEffect. Resolving per warning


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@karriebear karriebear marked this pull request as ready for review October 9, 2020 18:54
@karriebear karriebear requested a review from a team October 9, 2020 18:54
@karriebear karriebear merged commit 7fc3fa2 into streamlit:develop Oct 9, 2020
tconkling added a commit to tconkling/streamlit that referenced this pull request Oct 12, 2020
# By karrie (7) and others
# Via GitHub
* develop:
  Removing cache option from main menu if s4a (streamlit#2149)
  Fix empty deploy page (streamlit#2148)
  Don't wait for unit tests before starting Cypress (streamlit#2142)
  Fix formatting of st.file_uploader docstring (streamlit#2141)
  Fix broken link in 0.68 changelog (streamlit#2144)
  Fix useEffect warning (streamlit#2137)
  Add global GTM container (streamlit#2128)
  Allow Streamlit server to handle Range Requests (streamlit#1967)
  rename hosted to hostedAt (streamlit#2132)
  Update change log
  Update notices
  Up version to 0.68.0
  Rename hosted to hostedAt in tracking data (streamlit#2132)
  Inject tracking data (streamlit#2110)
  [Feature Branch] File uploader (streamlit#2130)
  links for docs (streamlit#2129)
  Upgrade ProtobufJS and fix build script (streamlit#2118)
  Refresh landing page (streamlit#2116)
  Improve docstrings + tutorials for Layout (streamlit#2117)
  Better 'streamlit run' error message when no extension provided (streamlit#2115)

# Conflicts:
#	frontend/src/components/elements/Video/Video.tsx
#	frontend/src/components/widgets/FileUploader/FileUploader.test.tsx
#	frontend/src/components/widgets/FileUploader/FileUploader.tsx
#	frontend/src/lib/utils.ts
@karriebear karriebear deleted the use-effect-pagination-warning branch October 15, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants