Merged
Conversation
* Copying over * Linting * Missed copy - Hashing + Media support * Sidebar UX cleanup * Testing cleanup * linting + cleanup * E2E * linting * Fix unit tests * Get snapshots * Styling cleanup * File sizing + state updating cleanup * File sizing + state updating cleanup * button cleanup + file deletion * Separate dropzone instructions into a new file * Separate dropzone instructions into a new file * Linting * Small/Error text styled componenting * a11y uploaded files * Spacing var * Whoops + button updates * Multile file uploader should return [] when empty * Visual design updates * linting/cleanup * Revert rejectFiles change * Fix tests * Address PR comments * Fix test * addressing quick pr comments * Whoops * fix tests * Readable tests * setState with function
* Update deprecation * Update test for deprecation
* Quick visual tweaks * linting
* Single file uploader replaces in 1 request * Update comments
akrolsmir
approved these changes
Oct 8, 2020
Contributor
akrolsmir
left a comment
akrolsmir
left a comment
There was a problem hiding this comment.
Not reading this line-by-line, but taking it on faith that each of the previous reviews (including the mega-review) did the right thing.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Oct 12, 2020
# By karrie (7) and others # Via GitHub * develop: Removing cache option from main menu if s4a (streamlit#2149) Fix empty deploy page (streamlit#2148) Don't wait for unit tests before starting Cypress (streamlit#2142) Fix formatting of st.file_uploader docstring (streamlit#2141) Fix broken link in 0.68 changelog (streamlit#2144) Fix useEffect warning (streamlit#2137) Add global GTM container (streamlit#2128) Allow Streamlit server to handle Range Requests (streamlit#1967) rename hosted to hostedAt (streamlit#2132) Update change log Update notices Up version to 0.68.0 Rename hosted to hostedAt in tracking data (streamlit#2132) Inject tracking data (streamlit#2110) [Feature Branch] File uploader (streamlit#2130) links for docs (streamlit#2129) Upgrade ProtobufJS and fix build script (streamlit#2118) Refresh landing page (streamlit#2116) Improve docstrings + tutorials for Layout (streamlit#2117) Better 'streamlit run' error message when no extension provided (streamlit#2115) # Conflicts: # frontend/src/components/elements/Video/Video.tsx # frontend/src/components/widgets/FileUploader/FileUploader.test.tsx # frontend/src/components/widgets/FileUploader/FileUploader.tsx # frontend/src/lib/utils.ts
|
@karriebear thanks for your hard work on this! both of the demos you linked above return a 404; can you point them in the right direction? |
Contributor
Author
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely redesigned
st.file_uploaderwith the following additional features. The redesigned file uploader also closes out the following bugs. This redesign does not include file persistence on disk or file picker functionalities. (Closes #1202, Closes #831)Features
Bugs
Demos
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.