Skip to content

[File Uploader] Fix docstrings#2121

Merged
karriebear merged 1 commit intostreamlit:feature/file-uploaderfrom
karriebear:file-uploader-docstrings
Oct 8, 2020
Merged

[File Uploader] Fix docstrings#2121
karriebear merged 1 commit intostreamlit:feature/file-uploaderfrom
karriebear:file-uploader-docstrings

Conversation

@karriebear
Copy link
Copy Markdown
Contributor

Updated docstrings per product review


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@karriebear karriebear requested a review from a team October 8, 2020 05:39
@karriebear karriebear changed the title Fix docstrings [File Uploader] Fix docstrings Oct 8, 2020
@karriebear karriebear merged commit cdec7e9 into streamlit:feature/file-uploader Oct 8, 2020
karriebear added a commit that referenced this pull request Oct 8, 2020
* File Uploader (#2013)

* Copying over

* Linting

* Missed copy - Hashing + Media support

* Sidebar UX cleanup

* Testing cleanup

* linting + cleanup

* E2E

* linting

* Fix unit tests

* Get snapshots

* Styling cleanup

* File sizing + state updating cleanup

* File sizing + state updating cleanup

* button cleanup + file deletion

* Separate dropzone instructions into a new file

* Separate dropzone instructions into a new file

* Linting

* Small/Error text styled componenting

* a11y uploaded files

* Spacing var

* Whoops + button updates

* Multile file uploader should return [] when empty

* Visual design updates

* linting/cleanup

* Revert rejectFiles change

* Fix tests

* Address PR comments

* Fix test

* addressing quick pr comments

* Whoops

* fix tests

* Readable tests

* setState with function

* [File Uploader] Update deprecation (#2123)

* Update deprecation

* Update test for deprecation

* Fix docstrings (#2121)

* [File Uploader] Missed visual tweaks (#2124)

* Quick visual tweaks

* linting

* [File uploader] Single upload reruns only once (#2122)

* Single file uploader replaces in 1 request

* Update comments
@karriebear karriebear deleted the file-uploader-docstrings branch October 15, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants