Skip to content

Remove hexagon layer from st.map, use Pandas for range computation, and other st.map improvements#20

Merged
tvst merged 9 commits intostreamlit:developfrom
tvst:stmap
Aug 27, 2019
Merged

Remove hexagon layer from st.map, use Pandas for range computation, and other st.map improvements#20
tvst merged 9 commits intostreamlit:developfrom
tvst:stmap

Conversation

@tvst
Copy link
Copy Markdown
Contributor

@tvst tvst commented Aug 27, 2019

I was doing the release and realized the new st.map was showing both a scatterplot layer and hexagon layer, when it should only show scatterplots. This PR fixes that.

...and since I was touching that code, I noticed a few other places it would be improved:

  1. We should use Pandas to compute min/max since it's faster than doing a loop in Python
  2. Some docstrings and exception messages needed a little love
  3. I realized DeckGlChart supports columns named lat/lon as well as latitude/longitude (this is handled in JS), so I made st.map support the both types as well.
  4. Since I removed the hex layer, I set the pitch to 0 to get a flat map.

@tvst tvst requested a review from arraydude August 27, 2019 05:39
@tvst tvst self-assigned this Aug 27, 2019
@tvst tvst merged commit 75bb549 into streamlit:develop Aug 27, 2019
@tvst tvst deleted the stmap branch August 27, 2019 18:52
tconkling added a commit to tconkling/streamlit that referenced this pull request Aug 27, 2019
* develop:
  ForwardMsg.metadata (streamlit#21)
  Remove hexagon layer from st.map, use Pandas for range computation, and other st.map improvements (streamlit#20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants