[horiz-layout] Add collapsible_container#1978
Merged
karriebear merged 9 commits intostreamlit:horiz-layoutfrom Sep 11, 2020
Merged
[horiz-layout] Add collapsible_container#1978karriebear merged 9 commits intostreamlit:horiz-layoutfrom
karriebear merged 9 commits intostreamlit:horiz-layoutfrom
Conversation
karriebear
commented
Sep 8, 2020
lib/streamlit/delta_generator.py
Outdated
Contributor
Author
There was a problem hiding this comment.
I was on the fence about adding a test for this. Let me know if you think we need.
karriebear
force-pushed
the
layout-expandable
branch
from
7abd3dd to
66eab75
Compare
karriebear
force-pushed
the
layout-expandable
branch
from
66eab75 to
1467dc8
Compare
karriebear
force-pushed
the
layout-expandable
branch
from
bd3af76 to
ebae6ba
Compare
karriebear
force-pushed
the
layout-expandable
branch
from
d2053df to
1878e7c
Compare
Contributor
|
Small idea, if one could define a |
karriebear
changed the title
karriebear
force-pushed
the
layout-expandable
branch
from
e00187c to
4b6d1f0
Compare
akrolsmir
reviewed
Sep 10, 2020
karriebear
force-pushed
the
layout-expandable
branch
from
531a853 to
5f1fc47
Compare
akrolsmir
added a commit
that referenced
this pull request
Sep 21, 2020
* [Horizontal Layout] Implement st.container() (#1961) * Fix up dg._block() to be dg.container() * Add a unit test * Add an e2e test for st.container * Minor cleanups * Clean up variable names and comments * Clean up deltaPath code and docs * [Horizontal Layout] Implement `with DG` (#1964) * Force reinstall of setuptools to 49.6.0 (#1962) * try updating in virtualenv * new cache * am i using 39.0.1 and if so why is it failing? * somewhere somehow we are upgrading to setuptools 50.0.3... but where..? * looks like somewhere between setup + pipenv-install we get a newer version of setuptools * looks like somewhere between setup + pipenv-install we get a newer version of setuptools * force reinstall * looks like it's test requirements messing us up? * force reinstall + cleanup debugs * Fix up dg._block() to be dg.container() * Add a unit test * Add an e2e test for st.container * Minor cleanups * Clean up variable names and comments * Clean up deltaPath code and docs * Organize DGs in a tree, to track the `with DG` * Enable `with` in every st.foo call * Appease mypy with # type: ignore * More sacrifices at the altar of mypy * Add unit and e2e tests for with * Actually, don't rely on each DG mixin to call _active_dg Revert "Appease mypy with # type: ignore" This reverts commit 4ba7c47. Revert "Enable `with` in every st.foo call" This reverts commit 9b467d6. * Use the active DG for all "protected" class methods * Clean up DG docs * Don't switch DGs from add_rows Per Karrie's suggestion Co-authored-by: karrie <[email protected]> * [horiz-layout] Add collapsible_container (#1978) * Add collapsible_container * Add default collapsed * make label required + initial docs * Consolidate with WIP column work * Address PR comments for more cleanliness * Update e2e tests * Rename collapsible container (#1993) * rename to expander * Fix tests * Rename collapsible to expandable * [Horiz Layout] Columns (#1979) * Implement columns with variable widths * Add a e2e test for columns * Add a unit test * Update Prettier to 1.19 to allow optional chaining https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining * Fix e2e test * Downgrade Prettier back to 1.18 * Empty columns now take up space * Remove duplicate function from merge conflict * Use flex-gap instead of margin, so column sides don't get padded * Minor tweaks requested by code review * Prefix new layout methods with `beta_` Co-authored-by: karrie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Closes #958
Description:
collapsible_container(label="", collapsed=False)_container_blockto be shared betweencontainerandcollapsible_containerPreview
Demo
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.