Skip to content

ComponentInstance unit tests#1956

Merged
tconkling merged 7 commits intostreamlit:developfrom
tconkling:tim/ComponentInstanceUnitTests
Sep 2, 2020
Merged

ComponentInstance unit tests#1956
tconkling merged 7 commits intostreamlit:developfrom
tconkling:tim/ComponentInstanceUnitTests

Conversation

@tconkling
Copy link
Copy Markdown
Contributor

@tconkling tconkling commented Sep 1, 2020

Unit tests for ComponentInstance.tsx

These involve slightly complex plumbing, because they're testing the communication between ComponentInstance and its iframe, which all happens via postMessage.

This PR supersedes #1689 - that PR can be closed.

@tconkling tconkling marked this pull request as ready for review September 2, 2020 02:32
@tconkling tconkling requested a review from a team September 2, 2020 02:32
})

describe("SET_FRAME_HEIGHT handler", () => {
it("Updates the frameHeight without re-rendering", () => {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase updates (just to be consistent)

})

it("handles dataframe values", () => {
// TODO by Henrikh
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add this to my to do list!

* develop:
  Update change log
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Add spacing to slider docs
  Up version to 0.66.0
  Switch statement to include ArrowTable (streamlit#1951)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Switch statement to include ArrowTable (streamlit#1951)
  Add deprecation label to st.deck_gl_chart (streamlit#1943)
  Pin setuptools to <= 49.6.0 (streamlit#1944)
@tconkling tconkling merged commit b850e76 into streamlit:develop Sep 2, 2020
@tconkling tconkling deleted the tim/ComponentInstanceUnitTests branch September 2, 2020 16:38
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 8, 2020
* develop:
  Migrate Modal to Baseweb (streamlit#1930)
  Update bl dependency to resolve CVE (streamlit#1965)
  Force reinstall of setuptools to 49.6.0 (streamlit#1962)
  ComponentInstance unit tests (streamlit#1956)
  Update change log
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Add spacing to slider docs
  Up version to 0.66.0
  Switch statement to include ArrowTable (streamlit#1951)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Switch statement to include ArrowTable (streamlit#1951)
  Add deprecation label to st.deck_gl_chart (streamlit#1943)
  Pin setuptools to <= 49.6.0 (streamlit#1944)
  DuplicateWidgetID error message should surface widget name (streamlit#1942)
  Set z-index of balloons to 1000000 to allow it to display over other elements. (streamlit#1934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants