Skip to content

Fix alignment of .. output:: command in st.write()#1955

Merged
karriebear merged 1 commit intostreamlit:developfrom
akrolsmir:fix-write-docs
Sep 1, 2020
Merged

Fix alignment of .. output:: command in st.write()#1955
karriebear merged 1 commit intostreamlit:developfrom
akrolsmir:fix-write-docs

Conversation

@akrolsmir
Copy link
Copy Markdown
Contributor

@akrolsmir akrolsmir commented Sep 1, 2020

I think this got introduced while copy+pasting because .. output was previously indented with 3 spaces, not 4, so my IDE decided to shrink that down into 0 spaces. This illustrates one of the drawbacks of relying on syntactically correct code inside of a docstring.

Alternatively, these warnings should have prevented us from submitting the PR and breaking these docs?

Anyways it's working now:

@akrolsmir akrolsmir requested a review from a team September 1, 2020 22:00
@karriebear karriebear merged commit ebebf28 into streamlit:develop Sep 1, 2020
karriebear pushed a commit to karriebear/streamlit that referenced this pull request Sep 2, 2020
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 2, 2020
* develop:
  Update change log
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Add spacing to slider docs
  Up version to 0.66.0
  Switch statement to include ArrowTable (streamlit#1951)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Switch statement to include ArrowTable (streamlit#1951)
  Add deprecation label to st.deck_gl_chart (streamlit#1943)
  Pin setuptools to <= 49.6.0 (streamlit#1944)
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 8, 2020
* develop:
  Migrate Modal to Baseweb (streamlit#1930)
  Update bl dependency to resolve CVE (streamlit#1965)
  Force reinstall of setuptools to 49.6.0 (streamlit#1962)
  ComponentInstance unit tests (streamlit#1956)
  Update change log
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Add spacing to slider docs
  Up version to 0.66.0
  Switch statement to include ArrowTable (streamlit#1951)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Switch statement to include ArrowTable (streamlit#1951)
  Add deprecation label to st.deck_gl_chart (streamlit#1943)
  Pin setuptools to <= 49.6.0 (streamlit#1944)
  DuplicateWidgetID error message should surface widget name (streamlit#1942)
  Set z-index of balloons to 1000000 to allow it to display over other elements. (streamlit#1934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants