Skip to content

Pin setuptools to <= 49.6.0#1944

Merged
karriebear merged 3 commits intostreamlit:developfrom
karriebear:hardcode-setuptools-49.6
Sep 1, 2020
Merged

Pin setuptools to <= 49.6.0#1944
karriebear merged 3 commits intostreamlit:developfrom
karriebear:hardcode-setuptools-49.6

Conversation

@karriebear
Copy link
Copy Markdown
Contributor

@karriebear karriebear commented Sep 1, 2020

Issue: setuptools version 50.0 seems to have several issues and is failing our CI. Created an issue for setup.py develop. See setuptools issue 2355.

This looks to fail occasionally on CI based on what version gets installed? Always fails locally with version 50.0

Description:

  1. Pin setuptool to version 49.6.0 or earlier.
  2. Created issue Unpin setuptools #1945 to unpin once resolved

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@karriebear karriebear requested a review from a team September 1, 2020 00:54
@karriebear karriebear mentioned this pull request Sep 1, 2020
Copy link
Copy Markdown
Contributor

@akrolsmir akrolsmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it!

@karriebear karriebear merged commit 4a9072d into streamlit:develop Sep 1, 2020
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 2, 2020
* develop:
  Update change log
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Add spacing to slider docs
  Up version to 0.66.0
  Switch statement to include ArrowTable (streamlit#1951)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Switch statement to include ArrowTable (streamlit#1951)
  Add deprecation label to st.deck_gl_chart (streamlit#1943)
  Pin setuptools to <= 49.6.0 (streamlit#1944)
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 8, 2020
* develop:
  Migrate Modal to Baseweb (streamlit#1930)
  Update bl dependency to resolve CVE (streamlit#1965)
  Force reinstall of setuptools to 49.6.0 (streamlit#1962)
  ComponentInstance unit tests (streamlit#1956)
  Update change log
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Fix alignment of `.. output::` command in st.write() (streamlit#1955)
  Add spacing to slider docs
  Up version to 0.66.0
  Switch statement to include ArrowTable (streamlit#1951)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Remove st.write from unsupported in sidebar (streamlit#1952)
  Switch statement to include ArrowTable (streamlit#1951)
  Add deprecation label to st.deck_gl_chart (streamlit#1943)
  Pin setuptools to <= 49.6.0 (streamlit#1944)
  DuplicateWidgetID error message should surface widget name (streamlit#1942)
  Set z-index of balloons to 1000000 to allow it to display over other elements. (streamlit#1934)
@karriebear karriebear deleted the hardcode-setuptools-49.6 branch October 1, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants