Add deprecation label to st.deck_gl_chart#1943
Merged
randyzwitch merged 3 commits intostreamlit:developfrom Sep 1, 2020
Merged
Add deprecation label to st.deck_gl_chart#1943randyzwitch merged 3 commits intostreamlit:developfrom
randyzwitch merged 3 commits intostreamlit:developfrom
Conversation
kantuni
added
the
type:docs
akrolsmir
approved these changes
Sep 1, 2020
Contributor
akrolsmir
left a comment
akrolsmir
left a comment
There was a problem hiding this comment.
LGTM! Though I wonder: can we remove deck_gl_chart altogether? In the deprecation warning, we've been telling people this is going to be gone from Streamlit as of 2020-05-01, and I'd love to remove code from our codebase wherever possible.
Collaborator
Author
I did it as part of my bug rotation. We just decided to add a deprecation warning first, then remove it. |
randyzwitch
approved these changes
Sep 1, 2020
Collaborator
Author
|
@akrolsmir, see #1950. |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Sep 2, 2020
* develop: Update change log Fix alignment of `.. output::` command in st.write() (streamlit#1955) Fix alignment of `.. output::` command in st.write() (streamlit#1955) Add spacing to slider docs Up version to 0.66.0 Switch statement to include ArrowTable (streamlit#1951) Remove st.write from unsupported in sidebar (streamlit#1952) Remove st.write from unsupported in sidebar (streamlit#1952) Switch statement to include ArrowTable (streamlit#1951) Add deprecation label to st.deck_gl_chart (streamlit#1943) Pin setuptools to <= 49.6.0 (streamlit#1944)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Sep 8, 2020
* develop: Migrate Modal to Baseweb (streamlit#1930) Update bl dependency to resolve CVE (streamlit#1965) Force reinstall of setuptools to 49.6.0 (streamlit#1962) ComponentInstance unit tests (streamlit#1956) Update change log Fix alignment of `.. output::` command in st.write() (streamlit#1955) Fix alignment of `.. output::` command in st.write() (streamlit#1955) Add spacing to slider docs Up version to 0.66.0 Switch statement to include ArrowTable (streamlit#1951) Remove st.write from unsupported in sidebar (streamlit#1952) Remove st.write from unsupported in sidebar (streamlit#1952) Switch statement to include ArrowTable (streamlit#1951) Add deprecation label to st.deck_gl_chart (streamlit#1943) Pin setuptools to <= 49.6.0 (streamlit#1944) DuplicateWidgetID error message should surface widget name (streamlit#1942) Set z-index of balloons to 1000000 to allow it to display over other elements. (streamlit#1934)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1457