Set z-index of balloons to 1000000 #1934
Merged
karriebear merged 1 commit intostreamlit:developfrom Aug 31, 2020
Merged
Conversation
karriebear
approved these changes
Aug 28, 2020
Contributor
karriebear
left a comment
karriebear
left a comment
There was a problem hiding this comment.
Looks good, thanks for the contribution @scottjohnson623!
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Sep 8, 2020
* develop: Migrate Modal to Baseweb (streamlit#1930) Update bl dependency to resolve CVE (streamlit#1965) Force reinstall of setuptools to 49.6.0 (streamlit#1962) ComponentInstance unit tests (streamlit#1956) Update change log Fix alignment of `.. output::` command in st.write() (streamlit#1955) Fix alignment of `.. output::` command in st.write() (streamlit#1955) Add spacing to slider docs Up version to 0.66.0 Switch statement to include ArrowTable (streamlit#1951) Remove st.write from unsupported in sidebar (streamlit#1952) Remove st.write from unsupported in sidebar (streamlit#1952) Switch statement to include ArrowTable (streamlit#1951) Add deprecation label to st.deck_gl_chart (streamlit#1943) Pin setuptools to <= 49.6.0 (streamlit#1944) DuplicateWidgetID error message should surface widget name (streamlit#1942) Set z-index of balloons to 1000000 to allow it to display over other elements. (streamlit#1934)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #1916
Set frontend/src/components/Balloons/Balloons.scss
style .balloons > .balloon to have z-index of 1000000
Before contributing (PLEASE READ!)
This helps make sure (1) two people aren't working on the same thing, (2) this is something Streamlit's maintainers believe should be implemented/fixed, (3) any API, UI, or deeper architectural changes that need to be implemented have been fully thought through by Streamlit's maintainers, and (4) your time is well spent!
More information in our wiki: https://github.com/streamlit/streamlit/wiki/Contributing
Issue: Please include a link to the issue you're addressing. If no issue exists, create one first and then link it here.
Description: Describe the changes you made to the code, so it's easier for the reader to navigate your pull request. Usually this is a bullet list.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.