LocalSourcesWatcher: blacklist venv and hidden folders#188
Merged
Conversation
tvst
approved these changes
Sep 26, 2019
Contributor
|
There were 2 failing e2e tests, but I merged anyway since they are unrelated to this PR. I believe our tests are still a bit flaky right now :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalSourcesWatcher blacklists conda folders (anaconda2/3, miniconda2/3) and any folder whose name starts with a
..For simplicity, the blacklist syntax now supports Unix glob patterns.
(Also, there are a few unrelated tests that I cleaned up while I was fixing the new tests that were written for this PR.)
Fixes #129