Skip to content

Heading Anchors Draft (In-Page Link Enhancement)#1854

Closed
wtype wants to merge 11 commits intostreamlit:developfrom
wtype:add-heading-anchors
Closed

Heading Anchors Draft (In-Page Link Enhancement)#1854
wtype wants to merge 11 commits intostreamlit:developfrom
wtype:add-heading-anchors

Conversation

@wtype
Copy link
Copy Markdown
Contributor

@wtype wtype commented Aug 13, 2020

Heading Anchors Initial Draft (#824)

@nthmost
Updated this from the previous draft. I at least wanted to get a working draft before checking in.

This is a thin solution to adding anchors to heading elements: st.title, st.header, st.subheader, st.write(md). Need to work with Streamlit's ecosystem correctly and add a robust solution for st.write.

Current setup

st.title('this is a title')
st.title('this is a title', 'this is its anchor text')

Renders

<a href="#this-is-a-title">
  <h1 id="this-is-a-title">this is a title</h1>
</a>

<a href="#this-is-its-anchor-text">
  <h1 id="this-is-its-anchor-text">this is a title</h1>
</a>

@wtype wtype changed the title Heading Anchors Draft (In-Page Link Enhancement #824) Heading Anchors Draft (In-Page Link Enhancement) Aug 13, 2020
@nthmost
Copy link
Copy Markdown
Contributor

nthmost commented Aug 20, 2020

Hey @wtype , thanks for your patience with our reply here.

We're having some internal discussions with respect to the implementation and spec that I gave you -- hang tight while we do a little more evaluation. There were some hidden complexities to this one.

Thanks again!

@wtype
Copy link
Copy Markdown
Contributor Author

wtype commented Aug 20, 2020

Thank you. I'll hold off until more information comes in.

@ghost ghost self-assigned this Dec 28, 2020
@ChrisDelClea
Copy link
Copy Markdown

Any updates on this one?

@nthmost
Copy link
Copy Markdown
Contributor

nthmost commented Feb 5, 2021

We have done a few more product iterations on this feature to the point where we should probably close this PR (and thank @wtype for the work done -- you definitely moved the needle, it just turned out Product wanted to refine the requirements a few times).

We will have a solution out by the end of this month. Thanks for your patience!

@wtype
Copy link
Copy Markdown
Contributor Author

wtype commented Feb 5, 2021

Thanks for the update @nthmost!

@wtype wtype closed this Feb 5, 2021
@BedirT
Copy link
Copy Markdown

BedirT commented Mar 14, 2023

Any update on this? @nthmost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants