Heading Anchors Draft (In-Page Link Enhancement)#1854
Closed
wtype wants to merge 11 commits intostreamlit:developfrom
Closed
Heading Anchors Draft (In-Page Link Enhancement)#1854wtype wants to merge 11 commits intostreamlit:developfrom
wtype wants to merge 11 commits intostreamlit:developfrom
Conversation
added 5 commits
August 12, 2020 17:38
added 3 commits
August 14, 2020 14:49
Contributor
|
Hey @wtype , thanks for your patience with our reply here. We're having some internal discussions with respect to the implementation and spec that I gave you -- hang tight while we do a little more evaluation. There were some hidden complexities to this one. Thanks again! |
Contributor
Author
|
Thank you. I'll hold off until more information comes in. |
|
Any updates on this one? |
Contributor
|
We have done a few more product iterations on this feature to the point where we should probably close this PR (and thank @wtype for the work done -- you definitely moved the needle, it just turned out Product wanted to refine the requirements a few times). We will have a solution out by the end of this month. Thanks for your patience! |
Contributor
Author
|
Thanks for the update @nthmost! |
|
Any update on this? @nthmost |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heading Anchors Initial Draft (#824)
@nthmost
Updated this from the previous draft. I at least wanted to get a working draft before checking in.
This is a thin solution to adding anchors to heading elements: st.title, st.header, st.subheader, st.write(md). Need to work with Streamlit's ecosystem correctly and add a robust solution for st.write.
Current setup
Renders