Closed
Conversation
akrolsmir
reviewed
Jul 10, 2020
frontend/src/components/widgets/CustomComponent/ComponentInstance.test.tsx
Show resolved
Hide resolved
frontend/src/components/widgets/CustomComponent/ComponentInstance.test.tsx
Show resolved
Hide resolved
frontend/src/components/widgets/CustomComponent/ComponentInstance.test.tsx
Show resolved
Hide resolved
Contributor
|
@kantuni and I chatted about this offline, and agreed that the way forward is to not test the class's private methods directly, but instead to create a mock component to test the data flow between This should be testing that args are delivered from |
tconkling
added a commit
that referenced
this pull request
Sep 2, 2020
Unit tests for `ComponentInstance.tsx` These involve slightly complex plumbing, because they're testing the communication between `ComponentInstance` and its iframe, which all happens via `postMessage`. This PR supersedes #1689 - that PR can be closed.
Contributor
|
Superseded by #1956 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.