Disable/Remove scroll when in full screen mode#1586
Merged
arraydude merged 4 commits intostreamlit:developfrom Jun 17, 2020
Merged
Disable/Remove scroll when in full screen mode#1586arraydude merged 4 commits intostreamlit:developfrom
arraydude merged 4 commits intostreamlit:developfrom
Conversation
kantuni
reviewed
Jun 17, 2020
|
|
||
| export interface Props { | ||
| width: number | ||
| height?: number |
Collaborator
There was a problem hiding this comment.
I would prefer keeping the props sorted, though we don't have a rule for that. Let me know what you think.
Contributor
Author
There was a problem hiding this comment.
Sorted in which way? but yes I'm agree
Contributor
Author
There was a problem hiding this comment.
Should I add a task for that?
Contributor
There was a problem hiding this comment.
Dissenting opinion: I don't think "alphabetical sorting" is a good policy for props, member variables, and what-have-you. There's often a more meaningful semantic sorting that the author imparts.
kantuni
reviewed
Jun 17, 2020
kantuni
reviewed
Jun 17, 2020
frontend/src/components/shared/FullScreenWrapper/FullScreenWrapper.tsx
Outdated
Show resolved
Hide resolved
kantuni
reviewed
Jun 17, 2020
frontend/src/components/shared/FullScreenWrapper/FullScreenWrapper.tsx
Outdated
Show resolved
Hide resolved
kantuni
approved these changes
Jun 17, 2020
tconkling
added a commit
that referenced
this pull request
Jun 22, 2020
* develop: Formatting changes from `make pyformat` (#1621) Add config to disable CSRF + conflict check with CORS (#1571) MediaFile Grace Period using KEEP_DELAY = 5 seconds (#1494) Fix server.cookieSecret config option. (#1603) Create a config option to toggle websocket compression (#1544) Remove Python 2 and Python 3.5 staleness (#1600) Disable/Remove scroll when in full screen mode (#1586) Better welcome message when running `streamlit hello` (#1585) Scale image to approximate size on screen (#1594)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: This PR fixes #1168
Description:
When fullscreen:
object-fit: containWhen not fullscreen: remains the same
Contribution License Agreement
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.