Skip to content

Version 0.61.0#1512

Merged
tvst merged 11 commits intostreamlit:developfrom
tvst:release
Jun 4, 2020
Merged

Version 0.61.0#1512
tvst merged 11 commits intostreamlit:developfrom
tvst:release

Conversation

@tvst
Copy link
Copy Markdown
Contributor

@tvst tvst commented May 31, 2020

No description provided.

tconkling and others added 11 commits June 3, 2020 13:15
Fixes streamlit#463

From a lines-of-code perspective, this is a trivial change; Tornado supports WebSocket compression out of the box, and this PR just flips the switch to enable it.

(This obviously adds a bit of memory and CPU overhead to each WebSocket connection.)
* Merge server and client view state changes
* Up resource class used for Python 3.8 tests in CircleCI

* Ooops resource classs change should have be to the "cypress" flow
Our `mypy` task has been failing in CircleCI.

The issue is that `pipenv` is failing to deterministically resolve dependency versions, and is frequently resolving our `tornado=>=5.0, <6.0` dependency to Tornado 6 (because of other transitive dependencies on Tornado).

The solution is to use the `--sequential` flag in our `pipenv install` build step. From the pipenv docs:

> Installation is intended to be as deterministic as possible — use the --sequential flag to increase this, if experiencing issues.

So: pipenv installation is intended to be as deterministic as possible, but it's also possible to "increase its determinism" with a flag! (I think this is...madness.)

This PR *also* cleans up and documents a few things that I found confusing while tracking this down (with @jrhone's help!):

- The `mypy` cache is now stored in the project directory (and gitignored), rather than in `/tmp`
- We expire our CircleCI virtualenv cache key every day; I documented why we do this.
- Added docs to the "Create virtualenv" CircleCI build step.
- Removed the protobuf-caching step from the CircleCI jobs, because it's not actually doing anything.
- Updated the mypy ini to target Python 3.8, and fixed a new mypy warning.
@tvst tvst marked this pull request as ready for review June 3, 2020 22:43
@tvst tvst requested review from a team and randyzwitch as code owners June 3, 2020 22:43
@tvst tvst merged commit f5fc0b4 into streamlit:develop Jun 4, 2020
@tvst tvst deleted the release branch June 4, 2020 04:33
tconkling added a commit that referenced this pull request Jun 6, 2020
* develop:
  Showing unsupported dialog if there's some problem with mediaDevices support (#1533)
  Version 0.61.0 (#1512)
  Tweak onboarding printouts (#1529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants