Merged
Conversation
Fixes streamlit#463 From a lines-of-code perspective, this is a trivial change; Tornado supports WebSocket compression out of the box, and this PR just flips the switch to enable it. (This obviously adds a bit of memory and CPU overhead to each WebSocket connection.)
* Merge server and client view state changes
* Up resource class used for Python 3.8 tests in CircleCI * Ooops resource classs change should have be to the "cypress" flow
Our `mypy` task has been failing in CircleCI. The issue is that `pipenv` is failing to deterministically resolve dependency versions, and is frequently resolving our `tornado=>=5.0, <6.0` dependency to Tornado 6 (because of other transitive dependencies on Tornado). The solution is to use the `--sequential` flag in our `pipenv install` build step. From the pipenv docs: > Installation is intended to be as deterministic as possible — use the --sequential flag to increase this, if experiencing issues. So: pipenv installation is intended to be as deterministic as possible, but it's also possible to "increase its determinism" with a flag! (I think this is...madness.) This PR *also* cleans up and documents a few things that I found confusing while tracking this down (with @jrhone's help!): - The `mypy` cache is now stored in the project directory (and gitignored), rather than in `/tmp` - We expire our CircleCI virtualenv cache key every day; I documented why we do this. - Added docs to the "Create virtualenv" CircleCI build step. - Removed the protobuf-caching step from the CircleCI jobs, because it's not actually doing anything. - Updated the mypy ini to target Python 3.8, and fixed a new mypy warning.
…dropped that PR for this launch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.