Stop react-markdown from converting "[foo]" to a link.#151
Merged
jrhone merged 6 commits intostreamlit:developfrom Sep 24, 2019
Merged
Stop react-markdown from converting "[foo]" to a link.#151jrhone merged 6 commits intostreamlit:developfrom
jrhone merged 6 commits intostreamlit:developfrom
Conversation
tvst
changed the title
tvst
approved these changes
Sep 23, 2019
| ) | ||
|
|
||
| const linkReferenceHasParens = (props: LinkReferenceProps): any => { | ||
| console.log(props) |
Contributor
There was a problem hiding this comment.
Remove console.log. If you really want to log this for future debugging, use logMessage from lib/log
| </a> | ||
| ) | ||
|
|
||
| const linkReferenceHasParens = (props: LinkReferenceProps): any => { |
Contributor
There was a problem hiding this comment.
Add comment explaining what this function does. It's not obvious.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Sep 25, 2019
# By Jonathan Rhone (3) and others # Via GitHub * develop: Text changes in ☰ menu and several CLI prompts (streamlit#180) add format option for slider widget and return texts for display values (streamlit#154) Merge ForwardMsg caching into develop (streamlit#178) e2e test for magic (streamlit#172) Bart example update (streamlit#179) Pedantic CircleCI cleanup (streamlit#174) Fix overwriting elements in the sidebar (streamlit#181) update vega lite chart snapshot (streamlit#183) Stop react-markdown from converting "[foo]" to a link. (streamlit#151) Issue 1204: Graphs using Vega-Lite (streamlit#56) Removing uber demo from streamlit repo (streamlit#159) # Conflicts: # lib/streamlit/DeltaGenerator.py
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
#150
Decription:
Stop react-markdown from converting
"[foo]"to a link.ReactMarkdownfor link-references that detects a missing url and doesn't convert to a link.