On windows, show emojis only if latest windows terminal#1490
Merged
karriebear merged 1 commit intostreamlit:developfrom May 26, 2020
Merged
Conversation
karriebear
force-pushed
the
bug/1451-emojis-on-windows-terminal
branch
from
8dfc3bb to
b430f1e
Compare
karriebear
force-pushed
the
bug/1451-emojis-on-windows-terminal
branch
from
b430f1e to
aba00c6
Compare
karriebear
commented
May 22, 2020
|
|
||
| # WT_SESSION is a Windows Terminal specific environment variable. If it exists, | ||
| # we are on the latest Windows Terminal that supports emojis | ||
| SHOW_EMOJIS = platform.system() != "Windows" or os.environ.get("WT_SESSION") |
Contributor
Author
There was a problem hiding this comment.
it's currently only used for EMAIL_PROMPT but thought it'd be nice to have for other messages
nthmost
approved these changes
May 22, 2020
Contributor
nthmost
left a comment
nthmost
left a comment
There was a problem hiding this comment.
Tested on Windows 10 in Conda and Powershell. Seems to be working as intended!
tconkling
added a commit
that referenced
this pull request
May 26, 2020
* develop: If it is a windows machine, check if terminal is latest version that supports emojis (#1490) Remove Python 2 check in 'hello' df demo (#1486) Update README (#1493) Fix broken link by removing unnecessary 'd' (#1492) Update doc references for RTD (#1485) Remove excess parenthesis from selectbox example (#1488) Upgrade patch versions (#1463) Update date_input to accept a range for a ranged datepicker (#1483) radio docstring consistency in format_func param (#1480) Hash func for Tensorflow saved model (#1468) Figure out which env we are in for RTD (#1473) Version 0.60.0 (#1460) Remove extra start_time parameter (#1470) Fix spelling mistake in hello demo (#1469)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
May 26, 2020
* feature/plugins: (26 commits) revert accidentally-committed datframe serialization breakage Example PyPI package (streamlit#1462) If it is a windows machine, check if terminal is latest version that supports emojis (streamlit#1490) Remove Python 2 check in 'hello' df demo (streamlit#1486) Update README (streamlit#1493) Fix broken link by removing unnecessary 'd' (streamlit#1492) Update doc references for RTD (streamlit#1485) Remove excess parenthesis from selectbox example (streamlit#1488) Upgrade patch versions (streamlit#1463) Update date_input to accept a range for a ranged datepicker (streamlit#1483) radio docstring consistency in format_func param (streamlit#1480) Hash func for Tensorflow saved model (streamlit#1468) Figure out which env we are in for RTD (streamlit#1473) Fix component examples Version 0.60.0 (streamlit#1460) Remove extra start_time parameter (streamlit#1470) Fix spelling mistake in hello demo (streamlit#1469) Keras model hash func (streamlit#1450) Add support for st.echo("below") to print echoed text below the Streamlit output (streamlit#1452) Update 3.5 references to 3.6 (streamlit#1444) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1451
Description:
Windows Terminal was the only terminal tested that supports emojis natively.
If windows machine, check for WT_SESSION, a windows terminal specific environment variable, to determine if emoji should be displayed
Terminals for windows tested for emoji support:
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.