Skip to content

Check build environment for RTD#1473

Merged
randyzwitch merged 1 commit intostreamlit:developfrom
randyzwitch:rtd_env_fix
May 19, 2020
Merged

Check build environment for RTD#1473
randyzwitch merged 1 commit intostreamlit:developfrom
randyzwitch:rtd_env_fix

Conversation

@randyzwitch
Copy link
Copy Markdown
Contributor

For enabling ReadtheDocs, hard-coded environment name, when in fact it changes based on stable vs. latest branch. Check for the presence of the environment directory before use, so that stable documentation builds.

@randyzwitch randyzwitch merged commit c3fbbaf into streamlit:develop May 19, 2020
@randyzwitch
Copy link
Copy Markdown
Contributor Author

Merging this to develop didn't break the develop branch build, so I take that as a good sign (i.e. that's the affirmative branch I test for in the if statement, so the logic appears to be working)

@randyzwitch randyzwitch deleted the rtd_env_fix branch May 19, 2020 13:28
tconkling added a commit that referenced this pull request May 26, 2020
* develop:
  If it is a windows machine, check if terminal is latest version that supports emojis (#1490)
  Remove Python 2 check in 'hello' df demo (#1486)
  Update README (#1493)
  Fix broken link by removing unnecessary 'd' (#1492)
  Update doc references for RTD (#1485)
  Remove excess parenthesis from selectbox example (#1488)
  Upgrade patch versions (#1463)
  Update date_input to accept a range for a ranged datepicker (#1483)
  radio docstring consistency in format_func param (#1480)
  Hash func for Tensorflow saved model (#1468)
  Figure out which env we are in for RTD (#1473)
  Version 0.60.0 (#1460)
  Remove extra start_time parameter (#1470)
  Fix spelling mistake in hello demo (#1469)
tconkling added a commit to tconkling/streamlit that referenced this pull request May 26, 2020
* feature/plugins: (26 commits)
  revert accidentally-committed datframe serialization breakage
  Example PyPI package (streamlit#1462)
  If it is a windows machine, check if terminal is latest version that supports emojis (streamlit#1490)
  Remove Python 2 check in 'hello' df demo (streamlit#1486)
  Update README (streamlit#1493)
  Fix broken link by removing unnecessary 'd' (streamlit#1492)
  Update doc references for RTD (streamlit#1485)
  Remove excess parenthesis from selectbox example (streamlit#1488)
  Upgrade patch versions (streamlit#1463)
  Update date_input to accept a range for a ranged datepicker (streamlit#1483)
  radio docstring consistency in format_func param (streamlit#1480)
  Hash func for Tensorflow saved model (streamlit#1468)
  Figure out which env we are in for RTD (streamlit#1473)
  Fix component examples
  Version 0.60.0 (streamlit#1460)
  Remove extra start_time parameter (streamlit#1470)
  Fix spelling mistake in hello demo (streamlit#1469)
  Keras model hash func (streamlit#1450)
  Add support for st.echo("below") to print echoed text below the Streamlit output (streamlit#1452)
  Update 3.5 references to 3.6 (streamlit#1444)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants