Skip to content

Example PyPI package#1462

Merged
kantuni merged 6 commits intostreamlit:feature/pluginsfrom
kantuni:feature/plugins
May 26, 2020
Merged

Example PyPI package#1462
kantuni merged 6 commits intostreamlit:feature/pluginsfrom
kantuni:feature/plugins

Conversation

@kantuni
Copy link
Copy Markdown
Collaborator

@kantuni kantuni commented May 17, 2020

No description provided.

@kantuni kantuni requested a review from tconkling May 17, 2020 18:45
@kantuni kantuni requested review from a team and randyzwitch as code owners May 17, 2020 18:45
@randyzwitch
Copy link
Copy Markdown
Contributor

Unless we're intentionally including this to keep a monorepo going, shouldn't this live in its own repo? The thought being 1) we want to give people a repo they can clone and build on and 2) to ensure that the custom component packages do not depend on anything in the Streamlit repository itself (only the public APIs people would see from a pip install streamlit)

@tconkling tconkling changed the base branch from develop to feature/plugins May 18, 2020 16:04
@kantuni kantuni merged commit 29d3e0d into streamlit:feature/plugins May 26, 2020
@kantuni
Copy link
Copy Markdown
Collaborator Author

kantuni commented May 26, 2020

Correct. We are going to move this into its own repo. It’s here now for development purposes only.

Comment on lines +137 to +144
args_json = {}
args_df = {}
for key, value in kwargs.items():
if type_util.is_dataframe_compatible(value):
args_df[key] = value
else:
args_json[key] = value

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes keep sneaking in!

tconkling added a commit to tconkling/streamlit that referenced this pull request May 26, 2020
* feature/plugins: (26 commits)
  revert accidentally-committed datframe serialization breakage
  Example PyPI package (streamlit#1462)
  If it is a windows machine, check if terminal is latest version that supports emojis (streamlit#1490)
  Remove Python 2 check in 'hello' df demo (streamlit#1486)
  Update README (streamlit#1493)
  Fix broken link by removing unnecessary 'd' (streamlit#1492)
  Update doc references for RTD (streamlit#1485)
  Remove excess parenthesis from selectbox example (streamlit#1488)
  Upgrade patch versions (streamlit#1463)
  Update date_input to accept a range for a ranged datepicker (streamlit#1483)
  radio docstring consistency in format_func param (streamlit#1480)
  Hash func for Tensorflow saved model (streamlit#1468)
  Figure out which env we are in for RTD (streamlit#1473)
  Fix component examples
  Version 0.60.0 (streamlit#1460)
  Remove extra start_time parameter (streamlit#1470)
  Fix spelling mistake in hello demo (streamlit#1469)
  Keras model hash func (streamlit#1450)
  Add support for st.echo("below") to print echoed text below the Streamlit output (streamlit#1452)
  Update 3.5 references to 3.6 (streamlit#1444)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants