Looks like I don't have the CircleCI required flags set right...is this a GitHub repo level setting?

scripts/run_bare_integration_tests.py needs to be updated

Do a search for py35, there are a few files with comments about py35 compatibility that could be updated.

Good point, I only searched for 3.5

Looks like I don't have the CircleCI required flags set right...is this a GitHub repo level setting?

Yes I believe there's something in the settings to update @tvst

Do a search for py35, there are a few files with comments about py35 compatibility that could be updated.

@jrhone some of these remaining changes are bigger questions to answer around removing the Python 2 and Python 3.5 shims. In run_bare_integration_tests.py, removing the shim assumes we've got good enough testing around async, and in [config_test.py, credentials_test.py, file_util_test.py], the shims are part of the codebase.

Keeping scope of this PR as-is, issues from additional files in #1444 (comment) will be addressed in separate PR in the future

Ok. I was thinking that because it would be a patch release, there wouldn't be any syntax changes, so I put 3.6.9 to test against the most recent that people could be using. Guess that's a philosophical question of the intent for our CI.

My point is that between 3.6.0 and 3.6.9, there should only have been bug fixes, no syntax changes under semver standards. So whether we use 3.6.0, 3.6.9 or anything in between shouldn't make any syntax errors arrive.

I chose 3.6.9, because to me, that's the one most likely to still be installed (since downloads from python.org would be for the newest patch release, conda install python=3.6 would install the newest patch, etc.). So that's my philosophical distinction...we can assume that no syntax changes have been made and use the most recent 3.6.x release, or we can guarantee that we won't be testing against any syntax changes by using 3.6.0 (because they wouldn't have occurred yet).

Doesn't matter to me either way, just explaining why I chose the highest instead of the lowest.

3.6.1 is failing in different ways on different runs:

Run 1:

tests/streamlit/caching_test.py::CacheTest::test_no_max_size *** Error in `/home/circleci/repo/venv/bin/python': double free or corruption (!prev): 0x000000000098f860 ***

Run 2:

tests/streamlit/Server_test.py::ServerTest::test_cache_clearing /bin/bash: line 6:  7769 Aborted                 (core dumped) PYTHONPATH=. pytest -v --junitxml=test-reports/pytest/junit.xml -l --cov=/home/circleci/repo/lib/tests --cov=/home/circleci/repo/lib/streamlit --cov-report=term-missing tests/ /home/circleci/repo/lib/tests /home/circleci/repo/lib/streamlit

Not sure what the next move is here. On the one hand, I can definitely be doing something wrong for the CircleCI configuration file. There also could be something wrong with the Docker container. Or the worst, we don't actually pass on 3.6. @jrhone any suggestions what to try here?

Python 3.6.0, 3.6.1, 3.6.2, 3.6.3, 3.6.4

• Fail

Python 3.6.5, 3.6.10

• Integration tests: python /home/circleci/repo/e2e/scripts/st_magic.py fails

Traceback (most recent call last):
  File "e2e/scripts/st_magic.py", line 116, in <module>
    async_loop.run_until_complete(async_with())
  File "/Users/jonathanrhone1/miniconda3/envs/sc36/lib/python3.6/asyncio/base_events.py", line 488, in run_until_complete
    return future.result()
  File "e2e/scripts/st_magic.py", line 105, in async_with
    @contextlib.asynccontextmanager
AttributeError: module 'contextlib' has no attribute 'asynccontextmanager'

https://docs.python.org/3/library/contextlib.html#contextlib.asynccontextmanager
New in version 3.7