Fix multiselect docstring example#1442
Merged
tvst merged 3 commits intostreamlit:developfrom May 13, 2020
Merged
Conversation
The docstring example had three small issues: * Added a missing comma at the end of the line * Default values (currently) need to be an actual list, so changed from a tuple * Order of parameters was wrong, putting the default before the options
randyzwitch
suggested changes
May 12, 2020
Add in ellipsis for line continuation
Contributor
Author
|
Is the failing cypress tests side an issue? Should I move this over to master rather than develop? |
Contributor
|
No, Cypress isn't an issue. |
randyzwitch
approved these changes
May 12, 2020
tvst
approved these changes
May 13, 2020
Contributor
tvst
left a comment
tvst
left a comment
There was a problem hiding this comment.
Looks good, but please address the comment before merging
| ('Yellow', 'Red') | ||
| ... ('Green', 'Yellow', 'Red', 'Blue')) | ||
| ... ('Green', 'Yellow', 'Red', 'Blue'), | ||
| ... ['Yellow', 'Red']) |
Contributor
There was a problem hiding this comment.
I think they should either both be tuples or both be lists.
Contributor
There was a problem hiding this comment.
Actually, I just went and fixed it 😉
tconkling
added a commit
that referenced
this pull request
May 18, 2020
* develop: Keras model hash func (#1450) Add support for st.echo("below") to print echoed text below the Streamlit output (#1452) Update 3.5 references to 3.6 (#1444) PyTorch model hash func (#1445) Fix link for pipenv in Getting Started (#1455) TextArea and TextInput max_chars (#1423) Fix multiselect docstring example (#1442) Configuring ReadtheDocs (#1435) Fix "strip()" bug when internal IP is None (#1434)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1441
Description:
The docstring example had three small issues:
Contribution License Agreement
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.