Fix bug for startup under windows#144
Merged
tvst merged 1 commit intostreamlit:developfrom Sep 19, 2019
Merged
Conversation
Contributor
|
Awesome, our first external contributor! Thanks for doing this 🎉 That said, we weren't expecting external contributors before launch (Oct 1st!), so we haven't set up our PR template accordingly. Can you add this to your PR to indicate that you agree with the Apache 2 license? (Lawyers be lawyering) Other than that, the PR looks good to me 👍 |
Contributor
|
Thanks! I just triggered the e2e tests, and when they're done I'll go ahead and merge. Thanks for contributing!! |
tvst
approved these changes
Sep 19, 2019
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Sep 23, 2019
* develop: Release 0.46.0 (streamlit#170) Magic fixes (streamlit#138) [docs] Add analytics; redirect /secret/docs; fix compilation problem (streamlit#149) Fix bug for startup under windows (streamlit#144) Responsive layout (streamlit#104) Add basic PR template Better method signatures (streamlit#88) Publish docs to both /docs and /secret/docs, until we deprecate /secret/docs in January. (streamlit#141) Rename/report2app (streamlit#126)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Sep 23, 2019
* develop: (54 commits) Removing uber demo from streamlit repo (streamlit#159) Release 0.46.0 (streamlit#170) Magic fixes (streamlit#138) [docs] Add analytics; redirect /secret/docs; fix compilation problem (streamlit#149) Fix bug for startup under windows (streamlit#144) Responsive layout (streamlit#104) Add basic PR template Better method signatures (streamlit#88) Publish docs to both /docs and /secret/docs, until we deprecate /secret/docs in January. (streamlit#141) Rename/report2app (streamlit#126) Test running streamlit commands "bare" (streamlit#133) Updates to LP and sidebar. (streamlit#134) tests for z-index of date input popover in sidebar (streamlit#131) cypress test for escaping html in markdown (streamlit#125) On a Mac, check if xcode installed before requiring watchdog (streamlit#91) [Docs] Fix st.slider API in tutorial (streamlit#98) Sidebar exceptions (streamlit#107) Fixing unbound local variable (streamlit#110) Support hashing dataframes with unhashable objects. Gracefully f… (streamlit#118) Fix hashing if the object has a name but the name is not a string. (streamlit#117) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug that hinders the startup under windows by using platform specific SIGQUIT signal.
[x] By checking this box, I agree that all contributions to this project are made under the Apache 2.0 license.