Summary

This PR restores the reactJsonViewCompat.ts compatibility shim for @microlink/react-json-view that was removed in a previous PR (#14380). It fixes an "Element type is invalid" error that occurs during local development with Vite 8 due to varying CommonJS interop module shapes.

Code Quality

The code quality is excellent. The compatibility shim is well-documented with clear intent, reasoning, and removal criteria. The resolveDefaultExport utility is clean and robust.

Test Coverage

The new resolveDefaultExport.test.ts provides comprehensive unit test coverage, including standard cases, deep nesting limits, and edge cases (null, undefined, primitives, arrays, etc.). Existing unit tests for the Json components should continue to pass.

Backwards Compatibility

There are no breaking changes. This is a purely internal fix for the development environment and will not affect existing users.

Security & Risk

No security concerns or regression risks identified. The changes are isolated to frontend module resolution for a specific component.

External test recommendation

• Recommend external_test: No
• Triggered categories: None
• Evidence:
  • frontend/lib/src/util/reactJsonViewCompat.ts: Only modifies how a third-party dependency is imported to handle Vite 8 interop.
• Suggested external_test focus areas: N/A
• Confidence: High
• Assumptions and gaps: None

Accessibility

No accessibility impact. The changes only affect module resolution, not the rendered DOM or interactive elements.

Recommendations

None. The changes are solid and ready to merge.

Verdict

APPROVED: The PR effectively resolves the local development issue with a robust, well-tested compatibility shim.

This is an automated AI review by gemini-3.1-pro.

Summary

This PR restores a compatibility shim for @microlink/react-json-view to handle Vite 8 CommonJS interop differences seen in local dev servers. It reroutes JSON viewer imports through reactJsonViewCompat and adds focused unit tests for nested default-export unwrapping.

Code Quality

The change is well-scoped and maintainable:

• Import-path updates are minimal and centralized in frontend/lib/src/util/reactJsonViewCompat.ts.
• The shim has clear intent, removal criteria, and references to Vite behavior.
• frontend/lib/src/util/resolveDefaultExport.test.ts provides good edge-case coverage for wrapper depth and primitive/null inputs.

No blocking code quality issues found.

Test Coverage

Coverage is good for the utility behavior introduced:

• Added unit tests in frontend/lib/src/util/resolveDefaultExport.test.ts cover direct, single/double/triple nested defaults and depth limiting behavior.
• Existing component tests for JSON rendering (Json and JsonViewer) continue to exercise rendering paths that consume the compat import.

Minor gap (non-blocking): this does not add an integration-style test that directly verifies reactJsonViewCompat against mocked module namespace shapes end-to-end.

Backwards Compatibility

No public API changes or protocol changes are introduced. This is backwards compatible and specifically restores local-dev behavior (make debug/make frontend-dev) that regressed after shim removal.

Security & Risk

No security-sensitive surfaces are changed:

• No auth/session/cookie/XSRF logic changes.
• No routing/WebSocket/server endpoint modifications.
• No new external requests, runtime code execution patterns, or dependency additions.

Primary risk is limited to JSON component rendering if unexpected module shapes exceed current unwrap depth; current implementation intentionally bounds depth.

External test recommendation

• Recommend external_test: No
• Triggered categories: None
• Evidence:
  • frontend/lib/src/util/reactJsonViewCompat.ts: frontend-only module interop normalization; no routing/auth/network/storage/policy changes.
  • frontend/lib/src/components/elements/Json/Json.tsx: import source switched to compat shim only.
  • frontend/lib/src/components/elements/Json/useJsonTooltip.ts: type import source switched only.
  • frontend/lib/src/components/widgets/DataFrame/columns/cells/JsonViewer.tsx: import source switched to compat shim only.
  • frontend/lib/src/util/resolveDefaultExport.test.ts: unit tests for export resolution helper.
• Suggested external_test focus areas:
  • Optional smoke-only check in externally hosted/embedded deployment that JSON elements still render (not required by current risk profile).
  • Optional parity check between production build and local dev server JSON rendering.
• Confidence: High
• Assumptions and gaps: Review is diff-based only; no runtime execution was performed in this pass.

Accessibility

No accessibility-impacting DOM/interaction changes were introduced. This PR only changes import wiring and utility behavior, so existing a11y characteristics remain unchanged.

Recommendations

1. Optional: add one focused unit test for reactJsonViewCompat that mocks @microlink/react-json-view module namespace shapes and asserts the default export is callable.

Verdict

APPROVED: The fix is narrowly scoped, addresses the reported local-dev regression, preserves backward compatibility, and introduces adequate utility-level test coverage.

This is an automated AI review by gpt-5.3-codex-high. Please verify the feedback and use your judgment.

Summary

This PR restores the reactJsonViewCompat.ts compatibility shim that was removed in #14380 when migrating from react-json-view to @microlink/react-json-view. The direct import from @microlink/react-json-view works in CI builds but fails in the local Vite 8 dev server (e.g., make debug or make frontend-dev) due to inconsistent CommonJS interop behavior. The shim uses the existing resolveDefaultExport utility (introduced in the Vite 7→8 upgrade, #14359) to normalize nested default export wrappers. Additionally, the PR adds comprehensive unit tests for resolveDefaultExport, which previously had no dedicated test coverage.

Changed files:

• frontend/lib/src/util/reactJsonViewCompat.ts — new file restoring the compat shim (updated for @microlink/react-json-view)
• frontend/lib/src/util/resolveDefaultExport.test.ts — new test file for the existing resolveDefaultExport utility
• frontend/lib/src/components/elements/Json/Json.tsx — import changed from direct @microlink/react-json-view to compat shim
• frontend/lib/src/components/elements/Json/useJsonTooltip.ts — type import changed to compat shim
• frontend/lib/src/components/widgets/DataFrame/columns/cells/JsonViewer.tsx — import changed to compat shim

Code Quality

The code is clean, well-structured, and follows existing patterns in the codebase:

• reactJsonViewCompat.ts: Excellent documentation with JSDoc explaining intent, why it exists, removal criteria, and Vite references. The implementation is a thin wrapper that delegates to the generic resolveDefaultExport utility and re-exports the relevant types. This is essentially the same pattern as the shim from the Vite 8 upgrade (chore: upgrade vite v7 -> v8 #14359), updated for the new package name.

• resolveDefaultExport.ts (existing, not changed in this PR): The iterative unwrapping approach with a maxDepth limit is a safe, bounded strategy that avoids walking arbitrary object graphs.

• resolveDefaultExport.test.ts: Comprehensive test coverage including CommonJS interop shapes (no wrapper, single/double/triple nested), depth limiting, and edge cases (null, undefined, primitives, arrays, objects without default). Tests follow Vitest conventions and the project's test guide.

• Import paths use the ~lib/ alias consistently across all consuming files.

No issues identified with code structure or maintainability.

Test Coverage

Unit tests:

• The new resolveDefaultExport.test.ts provides thorough coverage of the generic unwrapping utility with 14 test cases across three describe blocks.
• Existing tests in Json.test.tsx and JsonViewer.test.tsx implicitly validate that the compat shim correctly resolves the component (these tests render the Json components and assert on output).

E2E tests:

• No new E2E tests are needed. This is a build-infrastructure fix that does not change any user-facing behavior — the Json component functionality remains identical.

Test coverage is adequate for these changes.

Backwards Compatibility

No breaking changes. This PR restores a pattern that was previously in place (from the Vite 8 upgrade) and only redirects imports through an internal shim. The public API and component behavior are unchanged. The type re-exports (OnCopyProps, OnSelectProps) maintain the same API surface for consuming files.

Security & Risk

No security concerns:

• No new dependencies introduced — @microlink/react-json-view was already added in [chore] Migrate from unmaintained react-json-view to @microlink/react-json-view #14380.
• No changes to server endpoints, authentication, file handling, or any security-sensitive code.
• The resolveDefaultExport utility is bounded by maxDepth (default 3), preventing unbounded object traversal.
• This is a low-risk change that restores a known-working pattern.

Regression risk: Low. The change only affects how the @microlink/react-json-view module is imported at the module boundary level. The existing unit tests and E2E tests for Json elements validate that rendering behavior is preserved.

External test recommendation

• Recommend external_test: No
• Triggered categories: None
• Evidence:
  • All changes are confined to frontend module import paths (reactJsonViewCompat.ts, Json.tsx, useJsonTooltip.ts, JsonViewer.tsx)
  • No routing, auth, WebSocket, embedding, asset serving, cross-origin, storage, or security header changes
  • Pure build-infrastructure compatibility fix with no behavioral change
• Suggested external_test focus areas: N/A
• Confidence: High
• Assumptions and gaps: None — the change scope is narrow and fully contained in frontend import plumbing.

Accessibility

No accessibility impact. The rendered Json components are unchanged — only the internal import path for the ReactJson component is modified.

Recommendations

No blocking issues. Minor observations:

1. Consider adding a brief comment in the test file linking it to the compat shim that motivated the tests, e.g., a reference to reactJsonViewCompat.ts as the primary consumer of resolveDefaultExport. This would help future developers understand why this utility has dedicated tests.

2. The resolveDefaultExport function's early-exit on falsy resolvedValue (line 31 of resolveDefaultExport.ts) means a module with { default: 0 } or { default: "" } would not unwrap the default. This is fine for the current use case (React components are always truthy), but if the utility is ever used for non-component exports, this edge case could be surprising. A brief JSDoc note about this assumption would be helpful.

Verdict

APPROVED: Clean, well-documented restoration of a necessary Vite 8 CommonJS compatibility shim for @microlink/react-json-view, with good test coverage added for the underlying utility. No breaking changes, no security concerns, and low regression risk.

This is an automated AI review by opus-4.6-thinking.