Conversation
|
Tim has volunteered to review this, but let's chat before merging because I want to understand what this changes in the release process (if anything). |
|
Thanks @tvst and @tconkling. To add a bit of clarity, merging this doesn't mean the process is changing, it gives the option to change the process. Meaning, I'm not removing the All we would need to do would be revert this commit to remove it from the codebase, should we decide this isn't the right thing to do. |
tconkling
left a comment
tconkling
left a comment
There was a problem hiding this comment.
Seems reasonable, but I wonder about duplicating bits of our Makefile in the env_setup.sh script. It's not a huge deal, but can we use our existing build system?
* develop: Keras model hash func (#1450) Add support for st.echo("below") to print echoed text below the Streamlit output (#1452) Update 3.5 references to 3.6 (#1444) PyTorch model hash func (#1445) Fix link for pipenv in Getting Started (#1455) TextArea and TextInput max_chars (#1423) Fix multiselect docstring example (#1442) Configuring ReadtheDocs (#1435) Fix "strip()" bug when internal IP is None (#1434)
3 participants
PR adds minimum configuration options to build on ReadtheDocs hosted environment. PR is not intended to address/remove code from make process for building/submitting doc updates in current process.
Post merging to
develop, need to address the following:docs.streamlit.ioto point to RTDdevelopas latest (currently points tortd_testfor testing)stablebranch on documentation or wait until 0.60 comes out to keep version history consistent