Fix "strip()" bug when internal IP is None#1434
Merged
tvst merged 2 commits intostreamlit:developfrom May 12, 2020
Merged
Conversation
Contributor
|
Based on this comment, it's possible for Looks like it should be handled in your PR as well. |
Amey-D
approved these changes
May 11, 2020
Contributor
Author
|
Fine, fine! Fixed it now 😄 |
jrhone
reviewed
May 12, 2020
| ) | ||
| else: | ||
| _external_ip = response.strip() | ||
| _external_ip = None |
Contributor
There was a problem hiding this comment.
Not sure if we need this line since _external_ip is initialized to None above the function and if it ever has a value we won't get here.
Contributor
Author
There was a problem hiding this comment.
I know. I just thought this was more readable. It makes it absolutely clear what the value _external_ip will be. You don't have to read the whole function to understand it.
jrhone
approved these changes
May 12, 2020
Contributor
Nice! |
tconkling
added a commit
that referenced
this pull request
May 18, 2020
* develop: Keras model hash func (#1450) Add support for st.echo("below") to print echoed text below the Streamlit output (#1452) Update 3.5 references to 3.6 (#1444) PyTorch model hash func (#1445) Fix link for pipenv in Getting Started (#1455) TextArea and TextInput max_chars (#1423) Fix multiselect docstring example (#1442) Configuring ReadtheDocs (#1435) Fix "strip()" bug when internal IP is None (#1434)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #554