Skip to content

Fixing date_input | min and max selectable date issues#1426

Merged
arraydude merged 6 commits intostreamlit:developfrom
arraydude:741/DateInputMinMax
May 8, 2020
Merged

Fixing date_input | min and max selectable date issues#1426
arraydude merged 6 commits intostreamlit:developfrom
arraydude:741/DateInputMinMax

Conversation

@arraydude
Copy link
Copy Markdown
Contributor

@arraydude arraydude commented May 6, 2020

Issue: This PR fixes #741
Description:
New args:

  • min_date: default to 1970/1/1
  • max_date: using BaseWeb's defaults

Contribution License Agreement

By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@arraydude arraydude requested a review from a team as a code owner May 6, 2020 21:51
@arraydude arraydude changed the title Fixing date_input min and max selectable date issues Fixing date_input | min and max selectable date issues May 6, 2020
@tconkling tconkling self-requested a review May 6, 2020 22:44
Copy link
Copy Markdown
Contributor

@tconkling tconkling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Minor thing: the referenced bug is wrong. I think this fixes #741, not #744.

(Also, per today's discussion @tvst should take a look at this and approve the new min_date/max_date default args.)

arraydude added 4 commits May 7, 2020 16:52
- min instead of min_date
- max instead of max_date
- updated docs
Copy link
Copy Markdown
Contributor

@tvst tvst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but PTAL at the proposed max_value change

@arraydude arraydude merged commit c61d60b into streamlit:develop May 8, 2020
@arraydude arraydude deleted the 741/DateInputMinMax branch May 8, 2020 18:46
tconkling added a commit that referenced this pull request May 11, 2020
* develop:
  Add "make mini-devel" to install minimal dev dependencies (i.e. doesn't install all the test dependencies) (#1407)
  Fixing date_input | min and max selectable date issues (#1426)
  Torch Tensorbase hash func (#1394)
  Change list() cast (#1401)
  Add geo layers to DeckGlJsonChart (#1306)
  Clean up use of LoDash (#1404)
  Replace st.beta.*/st.experimental.* with st.beta_*/st.experimental_* (#1403)
  Release 0.59.0 (#1405)
  Setting textarea height and unit tests (#1411)
tconkling added a commit to tconkling/streamlit that referenced this pull request May 11, 2020
* feature/plugins:
  black reformatting
  Add "make mini-devel" to install minimal dev dependencies (i.e. doesn't install all the test dependencies) (streamlit#1407)
  Fixing date_input | min and max selectable date issues (streamlit#1426)
  Torch Tensorbase hash func (streamlit#1394)
  Change list() cast (streamlit#1401)
  Component template tweaks
  Components: alpha 2 cleanup (streamlit#1425)
  Fix dataframe support
  Add geo layers to DeckGlJsonChart (streamlit#1306)
  Clean up use of LoDash (streamlit#1404)
  Replace st.beta.*/st.experimental.* with st.beta_*/st.experimental_* (streamlit#1403)
  Release 0.59.0 (streamlit#1405)
  Setting textarea height and unit tests (streamlit#1411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

date_input cannot go before January, 2000

3 participants