TextArea and TextInput max_chars#1423
Merged
arraydude merged 11 commits intostreamlit:developfrom May 14, 2020
Merged
Conversation
tvst
suggested changes
May 7, 2020
Contributor
|
This is awesome, love the animation 😃 We're almost there. Just one thing missing: we should always show the "press enter" text, even when there's a counter. So I made a few mockups of how this could work:
My favorite solution is (B) (note that I'm using the "•" character as a separator). Is this doable in our code? If not, then (A) is OK too. Also: we should have a screenshot test of the counter text. |
tvst
approved these changes
May 13, 2020
Contributor
tvst
left a comment
tvst
left a comment
There was a problem hiding this comment.
Approved but I just noticed another small issue. PTAL at comments.
frontend/src/components/shared/InputInstructions/InputInstructions.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/shared/InputInstructions/InputInstructions.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/shared/InputInstructions/InputInstructions.tsx
Outdated
Show resolved
Hide resolved
tvst
approved these changes
May 14, 2020
tconkling
added a commit
that referenced
this pull request
May 18, 2020
* develop: Keras model hash func (#1450) Add support for st.echo("below") to print echoed text below the Streamlit output (#1452) Update 3.5 references to 3.6 (#1444) PyTorch model hash func (#1445) Fix link for pipenv in Getting Started (#1455) TextArea and TextInput max_chars (#1423) Fix multiselect docstring example (#1442) Configuring ReadtheDocs (#1435) Fix "strip()" bug when internal IP is None (#1434)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: This PR fixes #613
Description: Adding max_chars arg to text area and text input
Contribution License Agreement
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.