Skip to content

docs: fix duplicated word in media file manager comment#14154

Merged
lukasmasuch merged 1 commit intostreamlit:developfrom
Rohan5commit:docs-typo-20260301-streamlit-105036
Mar 2, 2026
Merged

docs: fix duplicated word in media file manager comment#14154
lukasmasuch merged 1 commit intostreamlit:developfrom
Rohan5commit:docs-typo-20260301-streamlit-105036

Conversation

@Rohan5commit
Copy link
Copy Markdown
Contributor

@Rohan5commit Rohan5commit commented Mar 1, 2026 •
edited
Loading

Describe your changes

  • Fix duplicated wording in a code comment in lib/streamlit/runtime/media_file_manager.py.
  • Changed This is is important so we can mark a file as "not to This is important so we can mark a file as "not.

Screenshot or video (only for visual changes)

  • N/A (no visual/UI changes)

GitHub Issue Link (if applicable)

  • N/A (trivial comment typo fix)

Testing Plan

  • Explanation of why no additional tests are needed: comment-only wording update; no runtime, API, or UI behavior changed.
  • Unit Tests (JS and/or Python): not required.
  • E2E Tests: not required.
  • Any manual testing needed?: none.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Copy Markdown
Contributor

snyk-io bot commented Mar 1, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 1, 2026

Thanks for contributing to Streamlit! 🎈

Please make sure you have read our Contributing Guide. You can find additional information about Streamlit development in the wiki.

The review process:

  1. Initial triage: A maintainer will apply labels, approve CI to run, and trigger AI-assisted reviews. Your PR may be flagged with status:needs-product-approval if the feature requires product team sign-off.

  2. Code review: A core maintainer will start reviewing your PR once:

    • It is marked as 'ready for review', not 'draft'
    • It has status:product-approved (or doesn't need it)
    • All CI checks pass
    • All AI review comments are addressed

We're receiving many contributions and have limited review bandwidth — please expect some delay. We appreciate your patience! 🙏

lukasmasuch
lukasmasuch approved these changes Mar 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukasmasuch lukasmasuch added security-assessment-completed impact:internal PR changes only affect internal code change:docs PR contains documentation change labels Mar 1, 2026
@lukasmasuch lukasmasuch enabled auto-merge (squash) March 1, 2026 12:19
auto-merge was automatically disabled March 2, 2026 02:21

Pull request was closed

@Rohan5commit Rohan5commit reopened this Mar 2, 2026
@lukasmasuch lukasmasuch merged commit 6638339 into streamlit:develop Mar 2, 2026
88 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasmasuch lukasmasuch lukasmasuch approved these changes

Assignees

No one assigned

Labels

change:docs PR contains documentation change impact:internal PR changes only affect internal code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rohan5commit @lukasmasuch