Add logger.hideWelcomeMessage config option#14118
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ PR preview is ready!
|
There was a problem hiding this comment.
Pull request overview
Adds a new hidden configuration option to suppress the startup “welcome / URLs” output printed by streamlit run, which is particularly useful in hosted/container environments where the default localhost/network URLs can be misleading.
Changes:
- Introduce hidden config option
logger.hideWelcomeMessage(defaultFalse). - Skip all
_print_url(...)CLI output inbootstrap.pywhen the option is enabled. - Minor grammar tweak to two Snowflake connection log messages.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/streamlit/config.py |
Defines the new hidden config option logger.hideWelcomeMessage. |
lib/streamlit/web/bootstrap.py |
Early-return in _print_url when the option is enabled, suppressing the welcome/URL block. |
lib/tests/streamlit/web/bootstrap_test.py |
Adds a unit test verifying _print_url produces no output when the option is enabled. |
lib/streamlit/connections/snowflake_connection.py |
Updates two INFO log strings for improved grammar (“Connect…” → “Connecting…”). |
9b79f8a to
f45a30d
Compare
Consolidated Code ReviewSummaryThis PR adds a new hidden config option Additionally, a minor grammar fix changes "Connect to Snowflake..." to "Connecting to Snowflake..." in two log messages in Files changed:
Reviewer AgreementBoth reviewers (
Reviewer DifferencesMinor differences in optional recommendations only (no disagreements on substance):
Resolution: Both suggestions are non-blocking nits. The Code QualityThe implementation is clean and minimal:
Test Coverage
Backwards CompatibilityNo breaking changes:
Security & RiskNo security concerns. Regression risk is minimal — a single early return gated by an explicit boolean config flag, with no side effects on network binding, auth, or request handling. AccessibilityNot applicable — backend-only Python changes with no frontend or UI impact. RecommendationsNo blocking issues. One minor suggestion for consideration:
VerdictAPPROVED: Both reviewers approved. The implementation is clean, well-scoped, backward compatible, and adequately tested. No critical or blocking issues were raised by any reviewer. Consolidated review by 📋 Review by `gpt-5.3-codex-high`SummaryThis PR adds a hidden config option, Code QualityThe changes are small, focused, and follow existing patterns in the config and bootstrap modules.
Test CoverageCoverage for the new behavior is good for a scoped config addition:
No e2e coverage was added, which is acceptable for this internal, hidden config path; residual risk is low and mostly limited to startup logging behavior. Backwards CompatibilityNo breaking changes detected.
Security & RiskNo security concerns identified. Regression risk appears low:
AccessibilityNo frontend/UI changes in this PR; accessibility impact is not applicable. Recommendations
VerdictAPPROVED: The implementation is focused, backward compatible, and adequately tested for the new hidden config behavior. This is an automated AI review by 📋 Review by `opus-4.6-thinking`SummaryThis PR adds a new hidden config option Additionally, a minor grammar fix changes "Connect to Snowflake..." to "Connecting to Snowflake..." in two log messages in Code QualityThe implementation is clean and minimal:
No issues with code structure or patterns. Test Coverage
Minor observations:
Overall, test coverage is adequate for the scope of this change. Backwards CompatibilityNo breaking changes:
Security & RiskNo security concerns identified:
AccessibilityNot applicable — this PR modifies only backend Python code (CLI output and config). No frontend or UI changes are involved. RecommendationsNo blocking issues. Minor suggestions for consideration:
VerdictAPPROVED: Clean, well-scoped addition of a hidden config option to suppress the welcome message in hosted environments. Implementation is correct, tests are adequate, and there are no backwards compatibility or security concerns. This is an automated AI review by |
Describe your changes
Add a new hidden config option that suppresses the welcome message
printed when starting a Streamlit server. This is useful in hosted
environments (like SiS) where the default messages show URLs and
external IP warnings that are misleading or inactionable (for example,
from the container's perspective, it may think that it's serving the app at
localhost, but we don't want to display that to the user).When enabled, the "Welcome to Streamlit" / "You can now view your
Streamlit app" message along with Local URL, Network URL, and
External URL information will not be printed.
We also tweak the grammar in some other logs in
lib/streamlit/connections/snowflake_connection.py, which is technically anorthogonal change but probably not worth creating a second PR for.
Testing Plan
streamlit hellowith the new config option set and verified that thewelcome message doesn't appear.