Skip to content

Setting textarea height and unit tests#1411

Merged
arraydude merged 3 commits intostreamlit:developfrom
arraydude:277/TextAreaHeight
May 6, 2020
Merged

Setting textarea height and unit tests#1411
arraydude merged 3 commits intostreamlit:developfrom
arraydude:277/TextAreaHeight

Conversation

@arraydude
Copy link
Copy Markdown
Contributor

Issue: This PR fixes #277

Description:

  • New parameter to set the height manually
  • If the height is already passed the user could change the height manually
  • Added unit testing

Contribution License Agreement

By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@arraydude arraydude requested a review from a team as a code owner May 4, 2020 16:58
@arraydude arraydude merged commit 9786f94 into streamlit:develop May 6, 2020
@arraydude arraydude deleted the 277/TextAreaHeight branch May 6, 2020 18:13
tconkling added a commit that referenced this pull request May 11, 2020
* develop:
  Add "make mini-devel" to install minimal dev dependencies (i.e. doesn't install all the test dependencies) (#1407)
  Fixing date_input | min and max selectable date issues (#1426)
  Torch Tensorbase hash func (#1394)
  Change list() cast (#1401)
  Add geo layers to DeckGlJsonChart (#1306)
  Clean up use of LoDash (#1404)
  Replace st.beta.*/st.experimental.* with st.beta_*/st.experimental_* (#1403)
  Release 0.59.0 (#1405)
  Setting textarea height and unit tests (#1411)
tconkling added a commit to tconkling/streamlit that referenced this pull request May 11, 2020
* feature/plugins:
  black reformatting
  Add "make mini-devel" to install minimal dev dependencies (i.e. doesn't install all the test dependencies) (streamlit#1407)
  Fixing date_input | min and max selectable date issues (streamlit#1426)
  Torch Tensorbase hash func (streamlit#1394)
  Change list() cast (streamlit#1401)
  Component template tweaks
  Components: alpha 2 cleanup (streamlit#1425)
  Fix dataframe support
  Add geo layers to DeckGlJsonChart (streamlit#1306)
  Clean up use of LoDash (streamlit#1404)
  Replace st.beta.*/st.experimental.* with st.beta_*/st.experimental_* (streamlit#1403)
  Release 0.59.0 (streamlit#1405)
  Setting textarea height and unit tests (streamlit#1411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the height of a text_area

2 participants