Add "make mini-devel" to install minimal dev dependencies (i.e. doesn't install all the test dependencies)#1407
Merged
tvst merged 6 commits intostreamlit:developfrom May 11, 2020
Merged
Conversation
tvst
force-pushed
the
mini-deps
branch
3 times, most recently
from
e1decf3 to
87a1270
Compare
…'t install all the test dependencies) For this to work, I moved the test dependencies out of Pipfile and into test-requirements.txt
Closed
jrhone
reviewed
May 7, 2020
jrhone
reviewed
May 7, 2020
jrhone
reviewed
May 7, 2020
jrhone
approved these changes
May 7, 2020
tconkling
added a commit
that referenced
this pull request
May 11, 2020
* develop: Add "make mini-devel" to install minimal dev dependencies (i.e. doesn't install all the test dependencies) (#1407) Fixing date_input | min and max selectable date issues (#1426) Torch Tensorbase hash func (#1394) Change list() cast (#1401) Add geo layers to DeckGlJsonChart (#1306) Clean up use of LoDash (#1404) Replace st.beta.*/st.experimental.* with st.beta_*/st.experimental_* (#1403) Release 0.59.0 (#1405) Setting textarea height and unit tests (#1411)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
May 11, 2020
* feature/plugins: black reformatting Add "make mini-devel" to install minimal dev dependencies (i.e. doesn't install all the test dependencies) (streamlit#1407) Fixing date_input | min and max selectable date issues (streamlit#1426) Torch Tensorbase hash func (streamlit#1394) Change list() cast (streamlit#1401) Component template tweaks Components: alpha 2 cleanup (streamlit#1425) Fix dataframe support Add geo layers to DeckGlJsonChart (streamlit#1306) Clean up use of LoDash (streamlit#1404) Replace st.beta.*/st.experimental.* with st.beta_*/st.experimental_* (streamlit#1403) Release 0.59.0 (streamlit#1405) Setting textarea height and unit tests (streamlit#1411)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
make mini-develcommand to our Makefile.make mini-develis the same asmake all-develbut only installs dependencies you need to develop locally, assuming you don't need to run tests on your own machine. This is useful because our tests bring in a ton of dependencies that don't have much to do with the majority of development that our engineers do.For this to work, I moved the test dependencies out of Pipfile and into
test-requirements.txt
This is based on this discussion, in our old private eng forums (which is now deprecated!)
https://discuss.streamlit.io/t/reducing-streamlit-dev-dependencies/2644/3